scripts/slave/recipe_modules/chromium_tests/api.py - Issue 1455563003: chromium_tests: do not add crash_service to compile targets if they already contain "all"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium_tests/api.py

Issue 1455563003: chromium_tests: do not add crash_service to compile targets if they already contain "all" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/chromium_tests/api.py

diff --git a/scripts/slave/recipe_modules/chromium_tests/api.py b/scripts/slave/recipe_modules/chromium_tests/api.py

index e0d38195ff26a9e49c11ded4a97fa4926ea2eacb..9835a9abbc128f02c6dcab72b8c24c02cee18038 100644

--- a/scripts/slave/recipe_modules/chromium_tests/api.py

+++ b/scripts/slave/recipe_modules/chromium_tests/api.py

@@ -326,7 +326,9 @@ class ChromiumTestsApi(recipe_api.RecipeApi):

compile_targets.update(t.compile_targets(self.m))

# Only add crash_service when we have explicit compile targets.

- if self.m.platform.is_win and compile_targets:

+ if (self.m.platform.is_win and

+ compile_targets and

+ 'all' not in compile_targets):

compile_targets.add('crash_service')

# Lastly, add any targets the checkout-side test spec told us to use.

« no previous file with comments | « no previous file | scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin.json » ('j') | no next file with comments »