Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_dbg_analyze.json

Issue 1455563003: chromium_tests: do not add crash_service to compile targets if they already contain "all" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_dbg_analyze.json
diff --git a/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_dbg_analyze.json b/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_dbg_analyze.json
index 3a2a7cbed2098a2b691cb3a6de0e9926f7a4a325..4ce5c4dc184af62370c15931b3e05517a329081d 100644
--- a/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_dbg_analyze.json
+++ b/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_dbg_analyze.json
@@ -215,7 +215,7 @@
"-u",
"[SLAVE_BUILD]\\src\\build\\gyp_chromium",
"--analyzer",
- "{\"additional_compile_targets\": [\"all\", \"crash_service\"], \"files\": [\"foo.cc\"], \"test_targets\": []}",
+ "{\"additional_compile_targets\": [\"all\"], \"files\": [\"foo.cc\"], \"test_targets\": []}",
"/path/to/tmp/json"
],
"cwd": "[SLAVE_BUILD]",
@@ -233,8 +233,7 @@
"@@@STEP_LOG_END@json.output@@@",
"@@@STEP_LOG_LINE@analyze_details@{@@@",
"@@@STEP_LOG_LINE@analyze_details@ \"additional_compile_targets\": [@@@",
- "@@@STEP_LOG_LINE@analyze_details@ \"all\", @@@",
- "@@@STEP_LOG_LINE@analyze_details@ \"crash_service\"@@@",
+ "@@@STEP_LOG_LINE@analyze_details@ \"all\"@@@",
"@@@STEP_LOG_LINE@analyze_details@ ], @@@",
"@@@STEP_LOG_LINE@analyze_details@ \"compile_targets\": [], @@@",
"@@@STEP_LOG_LINE@analyze_details@ \"self.m.filter.compile_targets\": [], @@@",

Powered by Google App Engine
This is Rietveld 408576698