FWL refcounts never incremented (part 2).

xfa/include/fwl/basewidget/fwl_checkbox.h

Index: xfa/include/fwl/basewidget/fwl_checkbox.h
diff --git a/xfa/include/fwl/basewidget/fwl_checkbox.h b/xfa/include/fwl/basewidget/fwl_checkbox.h
index 3e08a639723b21d0ff1456e15c411d2d91acb93a..6bb7454fe4af8418f86e747c574ff84d887047d1 100644
--- a/xfa/include/fwl/basewidget/fwl_checkbox.h
+++ b/xfa/include/fwl/basewidget/fwl_checkbox.h
@@ -68,21 +68,26 @@ class IFWL_CheckBoxDP : public IFWL_DataProvider {
  public:
   virtual FX_FLOAT GetBoxSize(IFWL_Widget* pWidget) = 0;
 };
+
 class IFWL_CheckBox : public IFWL_Widget {
  public:
-  IFWL_CheckBox();
-  FWL_ERR Initialize(const CFWL_WidgetImpProperties& properties,
-                     IFWL_Widget* pOuter);
+  static IFWL_CheckBox* Create(const CFWL_WidgetImpProperties& properties,
+                               IFWL_Widget* pOuter);

[Lei Zhang, 2015/12/09 03:43:42]

Always NULL

   int32_t GetCheckState();
   FWL_ERR SetCheckState(int32_t iCheck);
 
+ protected:
+  IFWL_CheckBox();
 };
+
 class IFWL_RadioButton : public IFWL_Widget {
  public:
-  IFWL_RadioButton();
-  FWL_ERR Initialize(const CFWL_WidgetImpProperties& properties,
-                     IFWL_Widget* pOuter);
+  static IFWL_RadioButton* Create(const CFWL_WidgetImpProperties& properties,

[Lei Zhang, 2015/12/09 03:43:42]

Never called?

[Tom Sepez, 2015/12/09 20:32:05]

And hence the class is unused.  removed.

+                                  IFWL_Widget* pOuter);
   int32_t GetCheckState();
   FWL_ERR SetCheckState(int32_t iCheck);
+
+ protected:
+  IFWL_RadioButton();
 };
 #endif