Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: xfa/include/fwl/basewidget/fwl_barcode.h

Issue 1453473002: FWL refcounts never incremented (part 2). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: Rebased past part1. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | xfa/include/fwl/basewidget/fwl_caret.h » ('j') | xfa/include/fwl/basewidget/fwl_checkbox.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/include/fwl/basewidget/fwl_barcode.h
diff --git a/xfa/include/fwl/basewidget/fwl_barcode.h b/xfa/include/fwl/basewidget/fwl_barcode.h
index 28b40baad1753b5c27268b4ac19ca6aaed77010d..3ec2b2b6af63567dc912267ff4c5cede4881dd4f 100644
--- a/xfa/include/fwl/basewidget/fwl_barcode.h
+++ b/xfa/include/fwl/basewidget/fwl_barcode.h
@@ -47,12 +47,15 @@ class IFWL_BarcodeDP : public IFWL_EditDP {
virtual FX_BOOL GetTruncated() = 0;
virtual FX_DWORD GetBarcodeAttributeMask() = 0;
};
+
class IFWL_Barcode : public IFWL_Edit {
public:
- IFWL_Barcode();
- FWL_ERR Initialize(const CFWL_WidgetImpProperties& properties,
- IFWL_Widget* pOuter);
+ static IFWL_Barcode* Create(const CFWL_WidgetImpProperties& properties,
+ IFWL_Widget* pOuter);
Lei Zhang 2015/12/09 03:43:42 |pOuter| is always NULL?
Tom Sepez 2015/12/09 20:32:05 Sure looks that way, even going back before this r
void SetType(BC_TYPE type);
FX_BOOL IsProtectedType();
+
+ protected:
+ IFWL_Barcode();
};
#endif
« no previous file with comments | « no previous file | xfa/include/fwl/basewidget/fwl_caret.h » ('j') | xfa/include/fwl/basewidget/fwl_checkbox.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698