FWL refcounts never incremented (part 2).

xfa/include/fwl/basewidget/fwl_combobox.h

Index: xfa/include/fwl/basewidget/fwl_combobox.h
diff --git a/xfa/include/fwl/basewidget/fwl_combobox.h b/xfa/include/fwl/basewidget/fwl_combobox.h
index 184d0107a47f09cb01b72bcaa42af97f638a8d9f..16c96bde800bc4570a42c7f6462e34fb4ea2eb2d 100644
--- a/xfa/include/fwl/basewidget/fwl_combobox.h
+++ b/xfa/include/fwl/basewidget/fwl_combobox.h
@@ -97,9 +97,9 @@ class IFWL_ComboBoxDP : public IFWL_ListBoxDP {
 };
 class IFWL_ComboBox : public IFWL_Widget {
  public:
-  IFWL_ComboBox();
-  FWL_ERR Initialize(const CFWL_WidgetImpProperties& properties,
-                     IFWL_Widget* pOuter);
+  static IFWL_ComboBox* Create(const CFWL_WidgetImpProperties& properties,
+                               IFWL_Widget* pOuter);

[Lei Zhang, 2015/12/09 03:43:42]

Always NULL.

[Tom Sepez, 2015/12/09 20:32:05]

Done.

+
   int32_t GetCurSel();
   FWL_ERR SetCurSel(int32_t iSel);
   FWL_ERR SetEditText(const CFX_WideString& wsText);
@@ -133,5 +133,8 @@ class IFWL_ComboBox : public IFWL_Widget {
   FWL_ERR GetBBox(CFX_RectF& rect);
   FWL_ERR EditModifyStylesEx(FX_DWORD dwStylesExAdded,
                              FX_DWORD dwStylesExRemoved);
+
+ protected:
+  IFWL_ComboBox();
 };
 #endif