FWL refcounts never incremented (part 2).

xfa/include/fwl/basewidget/fwl_checkbox.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef _FWL_CHECKBOX_H
 #define _FWL_CHECKBOX_H
 class CFWL_WidgetImpProperties;
 class IFWL_Widget;
 class IFWL_CheckBoxDP;
 class IFWL_CheckBox;
 #define FWL_CLASS_CheckBox L"FWL_CHECKBOX"
 #define FWL_CLASS_RadioButton L"FWL_RADIOBUTTON"

[Tom Sepez, 2015/12/09 20:40:04]

Note: the places these are checked always do radio/checkbox the same.

 #define FWL_CLASSHASH_CheckBox 4107183823
 #define FWL_CLASSHASH_RadioButton 3811304691
 #define FWL_STYLEEXT_CKB_Left (0L << 0)
 #define FWL_STYLEEXT_CKB_Center (1L << 0)
 #define FWL_STYLEEXT_CKB_Right (2L << 0)
 #define FWL_STYLEEXT_CKB_Top (0L << 2)
 #define FWL_STYLEEXT_CKB_VCenter (1L << 2)
 #define FWL_STYLEEXT_CKB_Bottom (2L << 2)
 #define FWL_STYLEEXT_CKB_LeftText (1L << 4)
 #define FWL_STYLEEXT_CKB_MultiLine (1L << 5)
 #define FWL_STYLEEXT_CKB_3State (1L << 6)
 #define FWL_STYLEEXT_CKB_RadioButton (1L << 7)

[Tom Sepez, 2015/12/09 20:40:04]

Note: A single class with this style attribute.  

 #define FWL_STYLEEXT_CKB_ShapeSolidSquare (0L << 8)
 #define FWL_STYLEEXT_CKB_ShapeSunkenSquare (1L << 8)
 #define FWL_STYLEEXT_CKB_ShapeSolidCircle (2L << 8)
 #define FWL_STYLEEXT_CKB_ShapeSunkenCircle (3L << 8)
 #define FWL_STYLEEXT_CKB_SignShapeCheck (0L << 10)
 #define FWL_STYLEEXT_CKB_SignShapeCircle (1L << 10)
 #define FWL_STYLEEXT_CKB_SignShapeCross (2L << 10)
 #define FWL_STYLEEXT_CKB_SignShapeDiamond (3L << 10)
 #define FWL_STYLEEXT_CKB_SignShapeSquare (4L << 10)
 #define FWL_STYLEEXT_CKB_SignShapeStar (5L << 10)
@@ skipping 24 matching lines @@
 #define FWL_PARTSTATE_CKB_Mask2 (3L << 2)
 #define FWL_EVT_CKB_CheckStateChanged L"FWL_EVENT_CKB_CheckStateChanged"
 #define FWL_EVTHASH_CKB_CheckStateChanged 2503252963
 BEGIN_FWL_EVENT_DEF(CFWL_EvtCkbCheckStateChanged,
                     FWL_EVTHASH_CKB_CheckStateChanged)
 END_FWL_EVENT_DEF
 class IFWL_CheckBoxDP : public IFWL_DataProvider {
  public:
   virtual FX_FLOAT GetBoxSize(IFWL_Widget* pWidget) = 0;
 };
+
 class IFWL_CheckBox : public IFWL_Widget {
  public:
-  IFWL_CheckBox();
-  FWL_ERR Initialize(const CFWL_WidgetImpProperties& properties,
-                     IFWL_Widget* pOuter);
+  static IFWL_CheckBox* Create(const CFWL_WidgetImpProperties& properties,
+                               IFWL_Widget* pOuter);

[Lei Zhang, 2015/12/09 03:43:42]

Always NULL

   int32_t GetCheckState();
   FWL_ERR SetCheckState(int32_t iCheck);
 
+ protected:
+  IFWL_CheckBox();
 };
+
 class IFWL_RadioButton : public IFWL_Widget {
  public:
-  IFWL_RadioButton();
-  FWL_ERR Initialize(const CFWL_WidgetImpProperties& properties,
-                     IFWL_Widget* pOuter);
+  static IFWL_RadioButton* Create(const CFWL_WidgetImpProperties& properties,

[Lei Zhang, 2015/12/09 03:43:42]

Never called?

[Tom Sepez, 2015/12/09 20:32:05]

And hence the class is unused.  removed.

+                                  IFWL_Widget* pOuter);
   int32_t GetCheckState();
   FWL_ERR SetCheckState(int32_t iCheck);
+
+ protected:
+  IFWL_RadioButton();
 };
 #endif