Subzero: Do some cleanup on the regalloc code.

Subzero: Do some cleanup on the regalloc code.

No functional changes, as measured by identical spec2k asm output.

1. Use early "return" and "continue" to reduce "if" nesting.

2. Reflow comments to 80 columns (instead of presumably 79).

3. Add some BuildDefs::dump() tests to reduce translator code size.

BUG= none
R=kschimpf@google.com

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=a1da6ff9af30f2cf95b9232f9d80f35e97514221

[Jim Stichnoth, 2015-11-15 18:02:25]

Description was changed from

==========
Subzero: Do some cleanup on the regalloc code.

BUG= none
==========

to

==========
Subzero: Do some cleanup on the regalloc code.

1. Use early "return" and "continue" to reduce "if" nesting.

2. Reflow comments to 80 columns (instead of presumably 79).

3. Add some BuildDefs::dump() tests to reduce translator code size.

BUG= none
==========

[Jim Stichnoth, 2015-11-15 18:24:34]

Description was changed from

==========
Subzero: Do some cleanup on the regalloc code.

1. Use early "return" and "continue" to reduce "if" nesting.

2. Reflow comments to 80 columns (instead of presumably 79).

3. Add some BuildDefs::dump() tests to reduce translator code size.

BUG= none
==========

to

==========
Subzero: Do some cleanup on the regalloc code.

No functional changes, as measured by identical spec2k asm output.

1. Use early "return" and "continue" to reduce "if" nesting.

2. Reflow comments to 80 columns (instead of presumably 79).

3. Add some BuildDefs::dump() tests to reduce translator code size.

BUG= none
==========

[Jim Stichnoth, 2015-11-15 18:24:34]

stichnot@chromium.org changed reviewers:
+ jpp@chromium.org, kschimpf@google.com, sehr@chromium.org

[Jim Stichnoth, 2015-11-15 18:24:43]

https://codereview.chromium.org/1448773002/diff/1/src/IceRegAlloc.cpp
File src/IceRegAlloc.cpp (right):

https://codereview.chromium.org/1448773002/diff/1/src/IceRegAlloc.cpp#newcode498
src/IceRegAlloc.cpp:498: const bool IsSingleDefAssign =
IsAssign and IsSingleDef are combined into IsSingleDefAssign.

https://codereview.chromium.org/1448773002/diff/1/src/IceRegAlloc.cpp#newcode513
src/IceRegAlloc.cpp:513: if (FindOverlap && IsSingleDefAssign &&
!Iter.Free[SrcReg]) {
Pull the IsSingleDefAssign test up here for slightly better efficiency.

[Karl, 2015-11-16 16:16:24]

lgtm

[Jim Stichnoth, 2015-11-16 23:59:42]

Committed patchset #2 (id:20001) manually as
a1da6ff9af30f2cf95b9232f9d80f35e97514221 (presubmit successful).