Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: src/IceTargetLowering.cpp

Issue 1448773002: Subzero: Do some cleanup on the regalloc code. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fix conditional Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceRegAlloc.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceTargetLowering.cpp
diff --git a/src/IceTargetLowering.cpp b/src/IceTargetLowering.cpp
index 0ee0afa2301929fa5e2596a709f0db2bd03e3886..94821ce64329e267601ba49f81bbef64538313ff 100644
--- a/src/IceTargetLowering.cpp
+++ b/src/IceTargetLowering.cpp
@@ -293,6 +293,11 @@ void TargetLowering::regAlloc(RegAllocKind Kind) {
Repeat = false;
Kind = RAK_SecondChance;
} while (Repeat);
+ // TODO(stichnot): Run the register allocator one more time to do stack slot
+ // coalescing. The idea would be to initialize the Unhandled list with the
+ // set of Variables that have no register and a non-empty live range, and
+ // model an infinite number of registers. Maybe use the register aliasing
+ // mechanism to get better packing of narrower slots.
}
void TargetLowering::markRedefinitions() {
« no previous file with comments | « src/IceRegAlloc.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698