Enable compilation of //components/autofill on iOS with gn.

Enable compilation of //components/autofill on iOS with gn.

Fix circular dependency between //components/autofill/{core,ios}/browser
by moving autofill_field_trial_ios.* and keyboard_accessory_metrics_logger.*
to //components/autofill/core/browser target.

Select the correct implementation of LoginDatabase (login_database_ios.cc)
instead of reusing the one from login_database_posix.cc.

Add BUILD.gn to for //components/autofill/ios/browser.

BUG=459705, 341429
Committed: https://crrev.com/cff08b58d85bd88cfb63c73d6ec628c922009c53
Cr-Commit-Position: refs/heads/master@{#359822}

[sdefresne, 2015-11-13 14:52:06]

sdefresne@chromium.org changed reviewers:
+ blundell@chromium.org

[sdefresne, 2015-11-13 14:52:06]

Please take a look.

This depends on https://codereview.chromium.org/1441323002 to land and be rolled
into Chromium for the compilation to succeed on iOS.

[vabr (Chromium), 2015-11-13 15:14:16]

vabr@chromium.org changed reviewers:
+ vabr@chromium.org

[vabr (Chromium), 2015-11-13 15:14:16]

This LGTM. The moved files, although iOS specific, seem reasonably isolated in
the usage, and abstracting them would make the code less readable.

Having said that, I'm surprised that there was no DEPS rule to allow the cycle.
We should add "-components/autofill/content" to autofill/DEPS.

Cheers,
Vaclav

[blundell, 2015-11-13 15:35:25]

lgtm

I'm not a huge fan of this structure but you didn't create the problem.

[sdefresne, 2015-11-13 16:27:30]

Patchset #1 (id:1) has been deleted

[sdefresne, 2015-11-16 10:45:31]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2015-11-16 10:45:31]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org,
blundell@chromium.org
Link to the patchset: https://codereview.chromium.org/1446473002/#ps20001
(title: "")

[commit-bot: I haz the power, 2015-11-16 10:46:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1446473002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1446473002/20001

[commit-bot: I haz the power, 2015-11-16 11:46:03]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2015-11-16 11:46:48]

Patchset 1 (id:??) landed as
https://crrev.com/cff08b58d85bd88cfb63c73d6ec628c922009c53
Cr-Commit-Position: refs/heads/master@{#359822}