components/password_manager/core/browser/BUILD.gn - Issue 1446473002: Enable compilation of //components/autofill on iOS with gn.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/BUILD.gn

Issue 1446473002: Enable compilation of //components/autofill on iOS with gn. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@os_crypt

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/ios/browser/keyboard_accessory_metrics_logger.mm ('k') | ios/chrome/browser/autofill/form_input_accessory_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/BUILD.gn

diff --git a/components/password_manager/core/browser/BUILD.gn b/components/password_manager/core/browser/BUILD.gn

index c36ff02819b29c043b3ed5224864e4df33505fad..579d6b9ba2f555b40146155cae0104cbf64b9551 100644

--- a/components/password_manager/core/browser/BUILD.gn

+++ b/components/password_manager/core/browser/BUILD.gn

@@ -48,6 +48,7 @@ source_set("browser") {

"log_router.h",

"login_database.cc",

"login_database.h",

+ "login_database_ios.cc",

"login_database_mac.cc",

"login_database_posix.cc",

"login_database_win.cc",

@@ -125,9 +126,7 @@ source_set("browser") {

"//url",

]

- if (is_mac) {

- # TODO(blundell): Provide the iOS login DB implementation and then

- # also exclude the POSIX one from iOS. http://crbug.com/341429

+ if (is_mac || is_ios) {

sources -= [ "login_database_posix.cc" ]

}