DescriptionEnable compilation of //components/password_manager on iOS with gn.
Link against the correct implementation of LoginDatabase for iOS
(login_database_ios.cc instead of login_database_posix.cc).
Add a missing dependency on //sql:test_support to unit_tests target
to fix the following link failures:
Undefined symbols for architecture arm64:
"sql::ScopedErrorIgnorer::IgnoreError(int)", referenced from:
password_manager::AffiliationDatabaseTest_Store_Test::TestBody() in affiliation_database_unittest.o
"sql::ScopedErrorIgnorer::CheckIgnoredErrors()", referenced from:
password_manager::AffiliationDatabaseTest_Store_Test::TestBody() in affiliation_database_unittest.o
"sql::ScopedErrorIgnorer::ScopedErrorIgnorer()", referenced from:
password_manager::AffiliationDatabaseTest_Store_Test::TestBody() in affiliation_database_unittest.o
"sql::ScopedErrorIgnorer::~ScopedErrorIgnorer()", referenced from:
password_manager::AffiliationDatabaseTest_Store_Test::TestBody() in affiliation_database_unittest.o
"sql::test::CorruptSizeInHeader(base::FilePath const&)", referenced from:
password_manager::AffiliationDatabaseTest_CorruptDBIsRazedThenOpened_Test::TestBody() in affiliation_database_unittest.o
password_manager::AffiliationDatabaseTest_CorruptDBGetsPoisoned_Test::TestBody() in affiliation_database_unittest.o
"sql::test::CreateDatabaseFromSQL(base::FilePath const&, base::FilePath const&)", referenced from:
password_manager::LoginDatabaseMigrationTest::CreateDatabase(base::BasicStringPiece<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >) in login_database_unittest.o
BUG=459705, 341429
Committed: https://crrev.com/372ad6b2c53a55690532d59b1ca6b1da1d6b3d93
Cr-Commit-Position: refs/heads/master@{#359851}
Patch Set 1 #
Depends on Patchset: Dependent Patchsets: Messages
Total messages: 12 (6 generated)
|