Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Issue 1436183004: Enable compilation of //components/password_manager on iOS with gn. (Closed)

Created:
5 years, 1 month ago by sdefresne
Modified:
5 years, 1 month ago
CC:
chromium-reviews, gcasto+watchlist_chromium.org, maxbogue+watch_chromium.org, mkwst+watchlist-passwords_chromium.org, plaree+watch_chromium.org, pvalenzuela+watch_chromium.org, tim+watch_chromium.org, vabr+watchlistpasswordmanager_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@autofill-fix
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable compilation of //components/password_manager on iOS with gn. Link against the correct implementation of LoginDatabase for iOS (login_database_ios.cc instead of login_database_posix.cc). Add a missing dependency on //sql:test_support to unit_tests target to fix the following link failures: Undefined symbols for architecture arm64: "sql::ScopedErrorIgnorer::IgnoreError(int)", referenced from: password_manager::AffiliationDatabaseTest_Store_Test::TestBody() in affiliation_database_unittest.o "sql::ScopedErrorIgnorer::CheckIgnoredErrors()", referenced from: password_manager::AffiliationDatabaseTest_Store_Test::TestBody() in affiliation_database_unittest.o "sql::ScopedErrorIgnorer::ScopedErrorIgnorer()", referenced from: password_manager::AffiliationDatabaseTest_Store_Test::TestBody() in affiliation_database_unittest.o "sql::ScopedErrorIgnorer::~ScopedErrorIgnorer()", referenced from: password_manager::AffiliationDatabaseTest_Store_Test::TestBody() in affiliation_database_unittest.o "sql::test::CorruptSizeInHeader(base::FilePath const&)", referenced from: password_manager::AffiliationDatabaseTest_CorruptDBIsRazedThenOpened_Test::TestBody() in affiliation_database_unittest.o password_manager::AffiliationDatabaseTest_CorruptDBGetsPoisoned_Test::TestBody() in affiliation_database_unittest.o "sql::test::CreateDatabaseFromSQL(base::FilePath const&, base::FilePath const&)", referenced from: password_manager::LoginDatabaseMigrationTest::CreateDatabase(base::BasicStringPiece<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >) in login_database_unittest.o BUG=459705, 341429 Committed: https://crrev.com/372ad6b2c53a55690532d59b1ca6b1da1d6b3d93 Cr-Commit-Position: refs/heads/master@{#359851}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M components/BUILD.gn View 4 chunks +6 lines, -5 lines 0 comments Download
M components/password_manager/core/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager/sync/browser/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
sdefresne
Please take a look.
5 years, 1 month ago (2015-11-13 15:02:59 UTC) #2
vabr (Chromium)
LGTM, thanks! Vaclav
5 years, 1 month ago (2015-11-13 15:16:07 UTC) #5
blundell
lgtm
5 years, 1 month ago (2015-11-13 15:36:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436183004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436183004/40001
5 years, 1 month ago (2015-11-16 15:45:03 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 1 month ago (2015-11-16 16:21:25 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 16:22:30 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/372ad6b2c53a55690532d59b1ca6b1da1d6b3d93
Cr-Commit-Position: refs/heads/master@{#359851}

Powered by Google App Engine
This is Rietveld 408576698