Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1443023002: Add a gn implementation for //ios/public/provider/web target. (Closed)

Created:
5 years, 1 month ago by sdefresne
Modified:
5 years, 1 month ago
Reviewers:
droger, Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@webp_transcode
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a gn implementation for //ios/public/provider/web target. BUG=459705 Committed: https://crrev.com/89308c9af62c4ccf24a05e7996e4d6e5c479b3ac Cr-Commit-Position: refs/heads/master@{#359812}

Patch Set 1 #

Patch Set 2 : Add reference to GN target #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/provider/ios_provider_web.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
A ios/public/provider/web/BUILD.gn View 1 chunk +21 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (7 generated)
sdefresne
dpranke: can you review //BUILD.gn? droger: can you review //ios/public/provider/web?
5 years, 1 month ago (2015-11-13 15:41:42 UTC) #2
droger
ios/public/provider/web/BUILD.gn lgtm
5 years, 1 month ago (2015-11-13 16:11:27 UTC) #3
Dirk Pranke
lgtm
5 years, 1 month ago (2015-11-13 17:27:35 UTC) #6
commit-bot: I haz the power
This CL has an open dependency (Issue 1444623002 Patch 1). Please resolve the dependency and ...
5 years, 1 month ago (2015-11-14 10:38:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1443023002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1443023002/40001
5 years, 1 month ago (2015-11-16 09:35:18 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 1 month ago (2015-11-16 10:40:43 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 10:41:54 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/89308c9af62c4ccf24a05e7996e4d6e5c479b3ac
Cr-Commit-Position: refs/heads/master@{#359812}

Powered by Google App Engine
This is Rietveld 408576698