Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 1440163003: Fix //ios/web target after http://crrev.com/1357773002. (Closed)

Created:
5 years, 1 month ago by sdefresne
Modified:
5 years, 1 month ago
Reviewers:
droger
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@enhanced_bookmarks
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix //ios/web target after http://crrev.com/1357773002. Update the list of files to follow what was done in ios_web.gyp and sort the dependencies. Remove a comment that is now obsolete as Chrome on iOS no longer depends on //content startup and instead uses //ios/web startup. Fix //ios/testing:ocmock_support dependencies on //third_party/ocmock and //third_party/google_toolbox_for_mac to public_deps as the usage is in public header files. BUG=459705, 547725 Committed: https://crrev.com/c1f1f87d6a7b38b02ea9ef755561651c52c01990 Cr-Commit-Position: refs/heads/master@{#359547}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -15 lines) Patch
M ios/testing/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/web/BUILD.gn View 7 chunks +8 lines, -15 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
sdefresne
Please take a look.
5 years, 1 month ago (2015-11-13 14:00:56 UTC) #2
droger
lgtm
5 years, 1 month ago (2015-11-13 14:16:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1440163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1440163003/1
5 years, 1 month ago (2015-11-13 14:30:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-13 14:37:58 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 14:39:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1f1f87d6a7b38b02ea9ef755561651c52c01990
Cr-Commit-Position: refs/heads/master@{#359547}

Powered by Google App Engine
This is Rietveld 408576698