Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1446463002: Fix dependency of //components/enhanced_bookmarks. (Closed)

Created:
5 years, 1 month ago by sdefresne
Modified:
5 years, 1 month ago
Reviewers:
blundell
CC:
chromium-reviews, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-ios
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix dependency of //components/enhanced_bookmarks. Remove stale #include in bookmark_server_cluster_service.h and remove the useless dependency on //components/keyed_service/content from the BUILD.gn file. BUG=459705 Committed: https://crrev.com/5ca1300cd84fe816764454cfb13f4c91e994e527 Cr-Commit-Position: refs/heads/master@{#359539}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M components/enhanced_bookmarks/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/enhanced_bookmarks/bookmark_server_cluster_service.h View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
sdefresne
PTAL
5 years, 1 month ago (2015-11-13 11:37:42 UTC) #2
blundell
lgtm
5 years, 1 month ago (2015-11-13 11:52:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1446463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1446463002/1
5 years, 1 month ago (2015-11-13 13:04:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-13 13:08:18 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 13:09:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5ca1300cd84fe816764454cfb13f4c91e994e527
Cr-Commit-Position: refs/heads/master@{#359539}

Powered by Google App Engine
This is Rietveld 408576698