Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 1439203003: Fix //components/os_crypt to build for iOS with gn. (Closed)

Created:
5 years, 1 month ago by sdefresne
Modified:
5 years, 1 month ago
Reviewers:
blundell
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@ios_web_fix
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix //components/os_crypt to build for iOS with gn. Use set_sources_assignment_filter to correctly select the correct implementation of KeychainPassword and OsCrypt to use on iOS (the same as on Mac). BUG=459705 Committed: https://crrev.com/3dcc7c59edd4cd5931d2f41b306211aa9ddb7a84 Cr-Commit-Position: refs/heads/master@{#359558}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M components/BUILD.gn View 4 chunks +2 lines, -2 lines 0 comments Download
M components/os_crypt/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
sdefresne
Please take a look.
5 years, 1 month ago (2015-11-13 14:44:04 UTC) #2
blundell
lgtm
5 years, 1 month ago (2015-11-13 15:30:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1439203003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1439203003/1
5 years, 1 month ago (2015-11-13 16:06:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-13 16:10:09 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 16:11:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3dcc7c59edd4cd5931d2f41b306211aa9ddb7a84
Cr-Commit-Position: refs/heads/master@{#359558}

Powered by Google App Engine
This is Rietveld 408576698