Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1444623002: Fix //third_party/libaddressinput:string target on iOS. (Closed)

Created:
5 years, 1 month ago by sdefresne
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@ios_web_fix
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix //third_party/libaddressinput:string target on iOS. Chrome on iOS uses different names for pt-BR and es-419 locales. Update third_party/libaddressinput/BUILD.gn to list different outputs when targetting iOS. BUG=459705 Committed: https://crrev.com/007b73df9250e4682cb6414f4143c83324cfbf39 Cr-Commit-Position: refs/heads/master@{#359746}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M third_party/libaddressinput/BUILD.gn View 1 chunk +12 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
sdefresne
Please take a look.
5 years, 1 month ago (2015-11-13 15:09:51 UTC) #2
please use gerrit instead
lgtm
5 years, 1 month ago (2015-11-13 16:23:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1444623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1444623002/1
5 years, 1 month ago (2015-11-14 09:12:02 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-15 02:31:46 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-15 02:32:25 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/007b73df9250e4682cb6414f4143c83324cfbf39
Cr-Commit-Position: refs/heads/master@{#359746}

Powered by Google App Engine
This is Rietveld 408576698