Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1440073002: Move XferProcessors to glsl (Closed)

Created:
5 years, 1 month ago by egdaniel
Modified:
5 years, 1 month ago
Reviewers:
joshualitt, joshua.litt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@fragProcs
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move XferProcessors to glsl This is basically a move and rename TBR=bsalomon@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/fa4cc8bf2aa782431609dd2ac16b1fc36de72e44

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -247 lines) Patch
M gyp/gpu.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M include/gpu/GrXferProcessor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkArithmeticMode_gpu.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/effects/GrCoverageSetOpXP.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/effects/GrCustomXfermode.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/effects/GrDisableColorXP.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/effects/GrPorterDuffXferProcessor.cpp View 13 chunks +13 lines, -13 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 chunk +1 line, -1 line 0 comments Download
D src/gpu/gl/GrGLXferProcessor.h View 1 chunk +0 lines, -90 lines 0 comments Download
D src/gpu/gl/GrGLXferProcessor.cpp View 1 chunk +0 lines, -97 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
A + src/gpu/glsl/GrGLSLXferProcessor.h View 3 chunks +11 lines, -11 lines 0 comments Download
A + src/gpu/glsl/GrGLSLXferProcessor.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/BUILD.public.expected View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
egdaniel
ptal
5 years, 1 month ago (2015-11-12 21:49:36 UTC) #2
joshualitt
On 2015/11/12 21:49:36, egdaniel wrote: > ptal lgtm
5 years, 1 month ago (2015-11-12 21:54:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1440073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1440073002/1
5 years, 1 month ago (2015-11-13 16:23:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1440073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1440073002/1
5 years, 1 month ago (2015-11-13 16:25:03 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 16:34:54 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/fa4cc8bf2aa782431609dd2ac16b1fc36de72e44

Powered by Google App Engine
This is Rietveld 408576698