Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1440063002: Use net::HostPortPair::HostForURL to fix IPv6 in URLs (Closed)

Created:
5 years, 1 month ago by Vitaly Buka (NO REVIEWS)
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@context4
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use net::HostPortPair::HostForURL to fix IPv6 in URLs BUG=549870 Committed: https://crrev.com/b2fa20e96627374327495a2538b9515f7d6784a7 Cr-Commit-Position: refs/heads/master@{#359471}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -268 lines) Patch
M chrome/browser/local_discovery/privet_http_asynchronous_factory_impl.cc View 2 chunks +1 line, -16 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/local_discovery/privet_http_unittest.cc View 1 30 chunks +197 lines, -251 lines 0 comments Download

Depends on Patchset:

Issue 1437193002 Patch 1

Dependent Patchsets:

Issue 1436373002 Patch 1

Messages

Total messages: 15 (7 generated)
Vitaly Buka (NO REVIEWS)
5 years, 1 month ago (2015-11-12 22:43:17 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1440063002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1440063002/40001
5 years, 1 month ago (2015-11-12 22:45:09 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-12 23:23:51 UTC) #7
Aleksey Shlyapnikov
lgtm
5 years, 1 month ago (2015-11-13 00:42:13 UTC) #8
commit-bot: I haz the power
This CL has an open dependency (Issue 1437193002 Patch 1). Please resolve the dependency and ...
5 years, 1 month ago (2015-11-13 00:44:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1440063002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1440063002/40001
5 years, 1 month ago (2015-11-13 01:42:23 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 1 month ago (2015-11-13 02:08:25 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 02:10:01 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b2fa20e96627374327495a2538b9515f7d6784a7
Cr-Commit-Position: refs/heads/master@{#359471}

Powered by Google App Engine
This is Rietveld 408576698