Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 1436373002: Fixed OSX crash in net::URLFetcherCore::URLFetcherCore (Closed)

Created:
5 years, 1 month ago by Vitaly Buka (NO REVIEWS)
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@context5
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed OSX crash in net::URLFetcherCore::URLFetcherCore Possible explanation is not implemented IPv6 resolution. Mac implementation keeps empty address there if only IPv6 is reported. So fix just implements coping of IPv6 address. BUG=513505 Committed: https://crrev.com/35f99d00a7e0d2316254af4e4d99da76292c3cbc Cr-Commit-Position: refs/heads/master@{#359630}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -37 lines) Patch
M chrome/browser/local_discovery/privet_http_asynchronous_factory_impl.cc View 1 2 chunks +13 lines, -4 lines 0 comments Download
M chrome/browser/local_discovery/privet_url_fetcher.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/local_discovery/privet_url_fetcher.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/local_discovery/service_discovery_client_mac.mm View 1 2 chunks +34 lines, -23 lines 0 comments Download
M chrome/browser/local_discovery/service_discovery_client_mac_unittest.mm View 1 2 3 chunks +30 lines, -9 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (8 generated)
Vitaly Buka (NO REVIEWS)
5 years, 1 month ago (2015-11-13 01:46:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436373002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436373002/20001
5 years, 1 month ago (2015-11-13 01:47:45 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 1 month ago (2015-11-13 01:47:47 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436373002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436373002/40001
5 years, 1 month ago (2015-11-13 19:53:58 UTC) #9
Aleksey Shlyapnikov
lgtm
5 years, 1 month ago (2015-11-13 20:00:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436373002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436373002/40001
5 years, 1 month ago (2015-11-13 20:09:03 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-13 20:53:32 UTC) #15
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/35f99d00a7e0d2316254af4e4d99da76292c3cbc Cr-Commit-Position: refs/heads/master@{#359630}
5 years, 1 month ago (2015-11-13 20:54:11 UTC) #16
Hezley Khez
5 years, 1 month ago (2015-11-13 21:10:14 UTC) #17
Message was sent while issue was closed.
On 2015/11/13 20:54:11, commit-bot: I haz the power wrote:
> Patchset 3 (id:??) landed as
> https://crrev.com/35f99d00a7e0d2316254af4e4d99da76292c3cbc
> Cr-Commit-Position: refs/heads/master@{#359630}

Powered by Google App Engine
This is Rietveld 408576698