Use net::HostPortPair::HostForURL to fix IPv6 in URLs

chrome/browser/local_discovery/privet_http_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 #include "base/location.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 15 matching lines @@
 #include "testing/gtest/include/gtest/gtest.h"
 
 #if defined(ENABLE_PRINT_PREVIEW)
 #include "chrome/browser/local_discovery/pwg_raster_converter.h"
 #endif  // ENABLE_PRINT_PREVIEW
 
 namespace local_discovery {
 
 namespace {
 
+using testing::NiceMock;
 using testing::StrictMock;
-using testing::NiceMock;
+using testing::TestWithParam;
+using testing::ValuesIn;
 
 using content::BrowserThread;
 using net::EmbeddedTestServer;
 
 const char kSampleInfoResponse[] = "{"
     "       \"version\": \"1.0\","
     "       \"name\": \"Common printer\","
     "       \"description\": \"Printer connected through Chrome connector\","
     "       \"url\": \"https://www.google.com/cloudprint\","
     "       \"type\": ["
@@ skipping 172 matching lines @@
     "}"
     "}";
 
 const char kSampleCJTDuplex[] =
     "{"
     "\"version\" : \"1.0\","
     "\"print\": { \"duplex\": {\"type\": \"SHORT_EDGE\"} }"
     "}";
 #endif  // ENABLE_PRINT_PREVIEW
 
+const char* const kTestParams[] = {"8.8.4.4", "2001:4860:4860::8888"};
+
 // Return the representation of the given JSON that would be outputted by
 // JSONWriter. This ensures the same JSON values are represented by the same
 // string.
 std::string NormalizeJson(const std::string& json) {
   std::string result = json;
   scoped_ptr<base::Value> value = base::JSONReader::Read(result);
-  DCHECK(value);
+  DCHECK(value) << result;
   base::JSONWriter::Write(*value, &result);
   return result;
 }
 
 class MockTestURLFetcherFactoryDelegate
     : public net::TestURLFetcher::DelegateForTests {
  public:
   // Callback issued correspondingly to the call to the |Start()| method.
   MOCK_METHOD1(OnRequestStart, void(int fetcher_id));
 
   // Callback issued correspondingly to the call to |AppendChunkToUpload|.
   // Uploaded chunks can be retrieved with the |upload_chunks()| getter.
   MOCK_METHOD1(OnChunkUpload, void(int fetcher_id));
 
   // Callback issued correspondingly to the destructor.
   MOCK_METHOD1(OnRequestEnd, void(int fetcher_id));
 };
 
-class PrivetHTTPTest : public ::testing::Test {
+class PrivetHTTPTest : public TestWithParam<const char*> {
  public:
   PrivetHTTPTest() {
     PrivetURLFetcher::ResetTokenMapForTests();
 
     request_context_ = new net::TestURLRequestContextGetter(
         base::ThreadTaskRunnerHandle::Get());
-    privet_client_ =
-        PrivetV1HTTPClient::CreateDefault(make_scoped_ptr<PrivetHTTPClient>(
-            new PrivetHTTPClientImpl("sampleDevice._privet._tcp.local",
-                                     net::HostPortPair("10.0.0.8", 6006),
-                                     request_context_.get())));
+    privet_client_ = PrivetV1HTTPClient::CreateDefault(
+        make_scoped_ptr<PrivetHTTPClient>(new PrivetHTTPClientImpl(
+            "sampleDevice._privet._tcp.local",
+            net::HostPortPair(GetParam(), 6006), request_context_.get())));
     fetcher_factory_.SetDelegateForTests(&fetcher_delegate_);
   }
 
-  virtual ~PrivetHTTPTest() {
+  GURL GetUrl(const std::string& path) const {
+    std::string host = GetParam();
+    if (host.find(":") != std::string::npos)
+      host = "[" + host + "]";
+    return GURL("http://" + host + ":6006" + path);
   }
 
   bool SuccessfulResponseToURL(const GURL& url,
                                const std::string& response) {
     net::TestURLFetcher* fetcher = fetcher_factory_.GetFetcherByID(0);
     EXPECT_TRUE(fetcher);
     EXPECT_EQ(url, fetcher->GetOriginalURL());
 
     if (!fetcher || url != fetcher->GetOriginalURL())
       return false;
@@ skipping 71 matching lines @@
  protected:
   base::MessageLoop loop_;
   scoped_refptr<net::TestURLRequestContextGetter> request_context_;
   net::TestURLFetcherFactory fetcher_factory_;
   scoped_ptr<PrivetV1HTTPClient> privet_client_;
   NiceMock<MockTestURLFetcherFactoryDelegate> fetcher_delegate_;
 };
 
 class MockJSONCallback{
  public:
-  MockJSONCallback() {}
-  ~MockJSONCallback() {}
-
   void OnPrivetJSONDone(const base::DictionaryValue* value) {
     if (!value) {
       value_.reset();
     } else {
       value_.reset(value->DeepCopy());
     }
 
     OnPrivetJSONDoneInternal();
   }
 
   MOCK_METHOD0(OnPrivetJSONDoneInternal, void());
 
   const base::DictionaryValue* value() { return value_.get(); }
   PrivetJSONOperation::ResultCallback callback() {
     return base::Bind(&MockJSONCallback::OnPrivetJSONDone,
                       base::Unretained(this));
   }
  protected:
   scoped_ptr<base::DictionaryValue> value_;
 };
 
 class MockRegisterDelegate : public PrivetRegisterOperation::Delegate {
  public:
-  MockRegisterDelegate() {
-  }
-  ~MockRegisterDelegate() {
-  }
-
   void OnPrivetRegisterClaimToken(
       PrivetRegisterOperation* operation,
       const std::string& token,
       const GURL& url) override {
     OnPrivetRegisterClaimTokenInternal(token, url);
   }
 
   MOCK_METHOD2(OnPrivetRegisterClaimTokenInternal, void(
       const std::string& token,
       const GURL& url));
@@ skipping 18 matching lines @@
       const std::string& device_id) override {
     OnPrivetRegisterDoneInternal(device_id);
   }
 
   MOCK_METHOD1(OnPrivetRegisterDoneInternal,
                void(const std::string& device_id));
 };
 
 class MockLocalPrintDelegate : public PrivetLocalPrintOperation::Delegate {
  public:
-  MockLocalPrintDelegate() {}
-  ~MockLocalPrintDelegate() {}
-
   virtual void OnPrivetPrintingDone(
       const PrivetLocalPrintOperation* print_operation) {
     OnPrivetPrintingDoneInternal();
   }
 
   MOCK_METHOD0(OnPrivetPrintingDoneInternal, void());
 
   virtual void OnPrivetPrintingError(
       const PrivetLocalPrintOperation* print_operation, int http_code) {
     OnPrivetPrintingErrorInternal(http_code);
   }
 
   MOCK_METHOD1(OnPrivetPrintingErrorInternal, void(int http_code));
 };
 
 class PrivetInfoTest : public PrivetHTTPTest {
  public:
-  PrivetInfoTest() {}
-
-  ~PrivetInfoTest() override {}
-
   void SetUp() override {
     info_operation_ = privet_client_->CreateInfoOperation(
         info_callback_.callback());
   }
 
  protected:
   scoped_ptr<PrivetJSONOperation> info_operation_;
   StrictMock<MockJSONCallback> info_callback_;
 };
 
-TEST_F(PrivetInfoTest, SuccessfulInfo) {
+INSTANTIATE_TEST_CASE_P(PrivetTests, PrivetInfoTest, ValuesIn(kTestParams));
+
+TEST_P(PrivetInfoTest, SuccessfulInfo) {
   info_operation_->Start();
 
   net::TestURLFetcher* fetcher = fetcher_factory_.GetFetcherByID(0);
   ASSERT_TRUE(fetcher != NULL);
-  EXPECT_EQ(GURL("http://10.0.0.8:6006/privet/info"),
-            fetcher->GetOriginalURL());
+  EXPECT_EQ(GetUrl("/privet/info"), fetcher->GetOriginalURL());
 
   fetcher->SetResponseString(kSampleInfoResponse);
   fetcher->set_status(net::URLRequestStatus(net::URLRequestStatus::SUCCESS,
                                             net::OK));
   fetcher->set_response_code(200);
 
   EXPECT_CALL(info_callback_, OnPrivetJSONDoneInternal());
   fetcher->delegate()->OnURLFetchComplete(fetcher);
 }
 
-TEST_F(PrivetInfoTest, InfoFailureHTTP) {
+TEST_P(PrivetInfoTest, InfoFailureHTTP) {
   info_operation_->Start();
 
   net::TestURLFetcher* fetcher = fetcher_factory_.GetFetcherByID(0);
   ASSERT_TRUE(fetcher != NULL);
   fetcher->set_status(net::URLRequestStatus(net::URLRequestStatus::SUCCESS,
                                             net::OK));
   fetcher->set_response_code(404);
 
   EXPECT_CALL(info_callback_, OnPrivetJSONDoneInternal());
   fetcher->delegate()->OnURLFetchComplete(fetcher);
 }
 
 class PrivetRegisterTest : public PrivetHTTPTest {
  public:
-  PrivetRegisterTest() {
-  }
-  ~PrivetRegisterTest() override {
-  }
-
   void SetUp() override {
     info_operation_ = privet_client_->CreateInfoOperation(
         info_callback_.callback());
     register_operation_ =
         privet_client_->CreateRegisterOperation("example@google.com",
                                                 &register_delegate_);
   }
 
  protected:
   bool SuccessfulResponseToURL(const GURL& url,
@@ skipping 11 matching lines @@
     fetcher->delegate()->OnURLFetchComplete(fetcher);
     return true;
   }
 
   scoped_ptr<PrivetJSONOperation> info_operation_;
   NiceMock<MockJSONCallback> info_callback_;
   scoped_ptr<PrivetRegisterOperation> register_operation_;
   StrictMock<MockRegisterDelegate> register_delegate_;
 };
 
-TEST_F(PrivetRegisterTest, RegisterSuccessSimple) {
+TEST_P(PrivetRegisterTest, RegisterSuccessSimple) {
   register_operation_->Start();
 
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/info"),
-      kSampleInfoResponse));
+  EXPECT_TRUE(
+      SuccessfulResponseToURL(GetUrl("/privet/info"), kSampleInfoResponse));
 
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/register?"
-           "action=start&user=example%40google.com"),
-      kSampleRegisterStartResponse));
+  EXPECT_TRUE(
+      SuccessfulResponseToURL(GetUrl("/privet/register?"
+                                     "action=start&user=example%40google.com"),
+                              kSampleRegisterStartResponse));
 
   EXPECT_CALL(register_delegate_, OnPrivetRegisterClaimTokenInternal(
       "MySampleToken",
       GURL("https://domain.com/SoMeUrL")));
 
   EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/register?"
-           "action=getClaimToken&user=example%40google.com"),
+      GetUrl("/privet/register?"
+             "action=getClaimToken&user=example%40google.com"),
       kSampleRegisterGetClaimTokenResponse));
 
   register_operation_->CompleteRegistration();
 
   EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/register?"
-           "action=complete&user=example%40google.com"),
+      GetUrl("/privet/register?"
+             "action=complete&user=example%40google.com"),
       kSampleRegisterCompleteResponse));
 
   EXPECT_CALL(register_delegate_, OnPrivetRegisterDoneInternal(
       "MyDeviceID"));
 
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/info"),
-      kSampleInfoResponseRegistered));
+  EXPECT_TRUE(SuccessfulResponseToURL(GetUrl("/privet/info"),
+                                      kSampleInfoResponseRegistered));
 }
 
-TEST_F(PrivetRegisterTest, RegisterXSRFFailure) {
+TEST_P(PrivetRegisterTest, RegisterXSRFFailure) {
   register_operation_->Start();
 
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/info"),
-      kSampleInfoResponse));
+  EXPECT_TRUE(
+      SuccessfulResponseToURL(GetUrl("/privet/info"), kSampleInfoResponse));
+
+  EXPECT_TRUE(
+      SuccessfulResponseToURL(GetUrl("/privet/register?"
+                                     "action=start&user=example%40google.com"),
+                              kSampleRegisterStartResponse));
 
   EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/register?"
-           "action=start&user=example%40google.com"),
-      kSampleRegisterStartResponse));
-
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/register?"
-           "action=getClaimToken&user=example%40google.com"),
+      GetUrl("/privet/register?"
+             "action=getClaimToken&user=example%40google.com"),
       kSampleXPrivetErrorResponse));
 
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/info"),
-      kSampleInfoResponse));
+  EXPECT_TRUE(
+      SuccessfulResponseToURL(GetUrl("/privet/info"), kSampleInfoResponse));
 
   EXPECT_CALL(register_delegate_, OnPrivetRegisterClaimTokenInternal(
       "MySampleToken", GURL("https://domain.com/SoMeUrL")));
 
   EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/register?"
-           "action=getClaimToken&user=example%40google.com"),
+      GetUrl("/privet/register?"
+             "action=getClaimToken&user=example%40google.com"),
       kSampleRegisterGetClaimTokenResponse));
 }
 
-TEST_F(PrivetRegisterTest, TransientFailure) {
+TEST_P(PrivetRegisterTest, TransientFailure) {
   register_operation_->Start();
 
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/info"),
-      kSampleInfoResponse));
+  EXPECT_TRUE(
+      SuccessfulResponseToURL(GetUrl("/privet/info"), kSampleInfoResponse));
 
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/register?"
-           "action=start&user=example%40google.com"),
-      kSampleRegisterErrorTransient));
+  EXPECT_TRUE(
+      SuccessfulResponseToURL(GetUrl("/privet/register?"
+                                     "action=start&user=example%40google.com"),
+                              kSampleRegisterErrorTransient));
 
   EXPECT_CALL(fetcher_delegate_, OnRequestStart(0));
 
   RunFor(base::TimeDelta::FromSeconds(2));
 
   testing::Mock::VerifyAndClearExpectations(&fetcher_delegate_);
 
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/register?"
-           "action=start&user=example%40google.com"),
-      kSampleRegisterStartResponse));
+  EXPECT_TRUE(
+      SuccessfulResponseToURL(GetUrl("/privet/register?"
+                                     "action=start&user=example%40google.com"),
+                              kSampleRegisterStartResponse));
 }
 
-TEST_F(PrivetRegisterTest, PermanentFailure) {
+TEST_P(PrivetRegisterTest, PermanentFailure) {
   register_operation_->Start();
 
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/info"),
-      kSampleInfoResponse));
+  EXPECT_TRUE(
+      SuccessfulResponseToURL(GetUrl("/privet/info"), kSampleInfoResponse));
 
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/register?"
-           "action=start&user=example%40google.com"),
-      kSampleRegisterStartResponse));
+  EXPECT_TRUE(
+      SuccessfulResponseToURL(GetUrl("/privet/register?"
+                                     "action=start&user=example%40google.com"),
+                              kSampleRegisterStartResponse));
 
   EXPECT_CALL(register_delegate_,
               OnPrivetRegisterErrorInternal(
                   "getClaimToken",
                   PrivetRegisterOperation::FAILURE_JSON_ERROR,
                   200));
 
   EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/register?"
-           "action=getClaimToken&user=example%40google.com"),
+      GetUrl("/privet/register?"
+             "action=getClaimToken&user=example%40google.com"),
       kSampleRegisterErrorPermanent));
 }
 
-TEST_F(PrivetRegisterTest, InfoFailure) {
+TEST_P(PrivetRegisterTest, InfoFailure) {
   register_operation_->Start();
 
   EXPECT_CALL(register_delegate_,
               OnPrivetRegisterErrorInternal(
                   "start",
                   PrivetRegisterOperation::FAILURE_TOKEN,
                   -1));
 
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/info"),
-      kSampleInfoResponseBadJson));
+  EXPECT_TRUE(SuccessfulResponseToURL(GetUrl("/privet/info"),
+                                      kSampleInfoResponseBadJson));
 }
 
-TEST_F(PrivetRegisterTest, RegisterCancel) {
+TEST_P(PrivetRegisterTest, RegisterCancel) {
   register_operation_->Start();
 
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/info"),
-      kSampleInfoResponse));
+  EXPECT_TRUE(
+      SuccessfulResponseToURL(GetUrl("/privet/info"), kSampleInfoResponse));
 
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/register?"
-           "action=start&user=example%40google.com"),
-      kSampleRegisterStartResponse));
+  EXPECT_TRUE(
+      SuccessfulResponseToURL(GetUrl("/privet/register?"
+                                     "action=start&user=example%40google.com"),
+                              kSampleRegisterStartResponse));
 
   register_operation_->Cancel();
 
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/register?"
-           "action=cancel&user=example%40google.com"),
-      kSampleRegisterCancelResponse));
+  EXPECT_TRUE(
+      SuccessfulResponseToURL(GetUrl("/privet/register?"
+                                     "action=cancel&user=example%40google.com"),
+                              kSampleRegisterCancelResponse));
 
   // Must keep mocks alive for 3 seconds so the cancelation object can be
   // deleted.
   RunFor(base::TimeDelta::FromSeconds(3));
 }
 
 class PrivetCapabilitiesTest : public PrivetHTTPTest {
  public:
-  PrivetCapabilitiesTest() {}
-
-  ~PrivetCapabilitiesTest() override {}
-
   void SetUp() override {
     capabilities_operation_ = privet_client_->CreateCapabilitiesOperation(
         capabilities_callback_.callback());
   }
 
  protected:
   scoped_ptr<PrivetJSONOperation> capabilities_operation_;
   StrictMock<MockJSONCallback> capabilities_callback_;
 };
 
-TEST_F(PrivetCapabilitiesTest, SuccessfulCapabilities) {
+INSTANTIATE_TEST_CASE_P(PrivetTests,
+                        PrivetCapabilitiesTest,
+                        ValuesIn(kTestParams));
+
+TEST_P(PrivetCapabilitiesTest, SuccessfulCapabilities) {
   capabilities_operation_->Start();
 
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/info"),
-      kSampleInfoResponse));
+  EXPECT_TRUE(
+      SuccessfulResponseToURL(GetUrl("/privet/info"), kSampleInfoResponse));
 
   EXPECT_CALL(capabilities_callback_, OnPrivetJSONDoneInternal());
 
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/capabilities"),
-      kSampleCapabilitiesResponse));
+  EXPECT_TRUE(SuccessfulResponseToURL(GetUrl("/privet/capabilities"),
+                                      kSampleCapabilitiesResponse));
 
   std::string version;
   EXPECT_TRUE(capabilities_callback_.value()->GetString("version", &version));
   EXPECT_EQ("1.0", version);
 }
 
-TEST_F(PrivetCapabilitiesTest, CacheToken) {
+TEST_P(PrivetCapabilitiesTest, CacheToken) {
   capabilities_operation_->Start();
 
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/info"),
-      kSampleInfoResponse));
+  EXPECT_TRUE(
+      SuccessfulResponseToURL(GetUrl("/privet/info"), kSampleInfoResponse));
 
   EXPECT_CALL(capabilities_callback_, OnPrivetJSONDoneInternal());
 
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/capabilities"),
-      kSampleCapabilitiesResponse));
+  EXPECT_TRUE(SuccessfulResponseToURL(GetUrl("/privet/capabilities"),
+                                      kSampleCapabilitiesResponse));
 
   capabilities_operation_ = privet_client_->CreateCapabilitiesOperation(
       capabilities_callback_.callback());
 
   capabilities_operation_->Start();
 
   EXPECT_CALL(capabilities_callback_, OnPrivetJSONDoneInternal());
 
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/capabilities"),
-      kSampleCapabilitiesResponse));
+  EXPECT_TRUE(SuccessfulResponseToURL(GetUrl("/privet/capabilities"),
+                                      kSampleCapabilitiesResponse));
 }
 
-TEST_F(PrivetCapabilitiesTest, BadToken) {
+TEST_P(PrivetCapabilitiesTest, BadToken) {
   capabilities_operation_->Start();
 
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/info"),
-      kSampleInfoResponse));
+  EXPECT_TRUE(
+      SuccessfulResponseToURL(GetUrl("/privet/info"), kSampleInfoResponse));
 
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/capabilities"),
-      kSampleXPrivetErrorResponse));
+  EXPECT_TRUE(SuccessfulResponseToURL(GetUrl("/privet/capabilities"),
+                                      kSampleXPrivetErrorResponse));
 
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/info"),
-      kSampleInfoResponse));
+  EXPECT_TRUE(
+      SuccessfulResponseToURL(GetUrl("/privet/info"), kSampleInfoResponse));
 
   EXPECT_CALL(capabilities_callback_, OnPrivetJSONDoneInternal());
 
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/capabilities"),
-      kSampleCapabilitiesResponse));
+  EXPECT_TRUE(SuccessfulResponseToURL(GetUrl("/privet/capabilities"),
+                                      kSampleCapabilitiesResponse));
 }
 
 #if defined(ENABLE_PRINT_PREVIEW)
 // A note on PWG raster conversion: The PWG raster converter used simply
 // converts strings to file paths based on them by appending "test.pdf", since
 // it's easier to test that way. Instead of using a mock, we simply check if the
 // request is uploading a file that is based on this pattern.
 class FakePWGRasterConverter : public PWGRasterConverter {
  public:
-  FakePWGRasterConverter() {
-  }
-
-  ~FakePWGRasterConverter() override {}
-
   void Start(base::RefCountedMemory* data,
              const printing::PdfRenderSettings& conversion_settings,
              const printing::PwgRasterSettings& bitmap_settings,
              const ResultCallback& callback) override {
     bitmap_settings_ = bitmap_settings;
     std::string data_str(data->front_as<char>(), data->size());
     callback.Run(true, base::FilePath().AppendASCII(data_str + "test.pdf"));
   }
 
   const printing::PwgRasterSettings& bitmap_settings() {
     return bitmap_settings_;
   }
 
  private:
   printing::PwgRasterSettings bitmap_settings_;
 };
 
 class PrivetLocalPrintTest : public PrivetHTTPTest {
  public:
-  PrivetLocalPrintTest() {}
-
-  ~PrivetLocalPrintTest() override {}
-
   void SetUp() override {
     PrivetURLFetcher::ResetTokenMapForTests();
 
     local_print_operation_ = privet_client_->CreateLocalPrintOperation(
         &local_print_delegate_);
 
     scoped_ptr<FakePWGRasterConverter> pwg_converter(
         new FakePWGRasterConverter);
     pwg_converter_ = pwg_converter.get();
     local_print_operation_->SetPWGRasterConverterForTesting(
         pwg_converter.Pass());
   }
 
   scoped_refptr<base::RefCountedBytes> RefCountedBytesFromString(
       std::string str) {
     std::vector<unsigned char> str_vec;
     str_vec.insert(str_vec.begin(), str.begin(), str.end());
     return scoped_refptr<base::RefCountedBytes>(
         base::RefCountedBytes::TakeVector(&str_vec));
   }
 
  protected:
   scoped_ptr<PrivetLocalPrintOperation> local_print_operation_;
   StrictMock<MockLocalPrintDelegate> local_print_delegate_;
   FakePWGRasterConverter* pwg_converter_;
 };
 
-TEST_F(PrivetLocalPrintTest, SuccessfulLocalPrint) {
+INSTANTIATE_TEST_CASE_P(PrivetTests,
+                        PrivetLocalPrintTest,
+                        ValuesIn(kTestParams));
+
+TEST_P(PrivetLocalPrintTest, SuccessfulLocalPrint) {
   local_print_operation_->SetUsername("sample@gmail.com");
   local_print_operation_->SetJobname("Sample job name");
   local_print_operation_->SetData(RefCountedBytesFromString(
       "Sample print data"));
   local_print_operation_->SetCapabilities(kSampleCapabilitiesResponse);
   local_print_operation_->Start();
 
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/info"),
-      kSampleInfoResponse));
+  EXPECT_TRUE(
+      SuccessfulResponseToURL(GetUrl("/privet/info"), kSampleInfoResponse));
 
-  EXPECT_TRUE(SuccessfulResponseToURL(GURL("http://10.0.0.8:6006/privet/info"),
-                                      kSampleInfoResponse));
+  EXPECT_TRUE(
+      SuccessfulResponseToURL(GetUrl("/privet/info"), kSampleInfoResponse));
 
   EXPECT_CALL(local_print_delegate_, OnPrivetPrintingDoneInternal());
 
   // TODO(noamsml): Is encoding spaces as pluses standard?
   EXPECT_TRUE(SuccessfulResponseToURLAndData(
-      GURL("http://10.0.0.8:6006/privet/printer/submitdoc?"
-           "client_name=Chrome&user_name=sample%40gmail.com&"
-           "job_name=Sample+job+name"),
-      "Sample print data",
-      kSampleLocalPrintResponse));
+      GetUrl("/privet/printer/submitdoc?"
+             "client_name=Chrome&user_name=sample%40gmail.com&"
+             "job_name=Sample+job+name"),
+      "Sample print data", kSampleLocalPrintResponse));
 }
 
-TEST_F(PrivetLocalPrintTest, SuccessfulLocalPrintWithAnyMimetype) {
+TEST_P(PrivetLocalPrintTest, SuccessfulLocalPrintWithAnyMimetype) {
   local_print_operation_->SetUsername("sample@gmail.com");
   local_print_operation_->SetJobname("Sample job name");
   local_print_operation_->SetData(
       RefCountedBytesFromString("Sample print data"));
   local_print_operation_->SetCapabilities(
       kSampleCapabilitiesResponseWithAnyMimetype);
   local_print_operation_->Start();
 
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/info"),
-      kSampleInfoResponse));
+  EXPECT_TRUE(
+      SuccessfulResponseToURL(GetUrl("/privet/info"), kSampleInfoResponse));
 
-  EXPECT_TRUE(SuccessfulResponseToURL(GURL("http://10.0.0.8:6006/privet/info"),
-                                      kSampleInfoResponse));
+  EXPECT_TRUE(
+      SuccessfulResponseToURL(GetUrl("/privet/info"), kSampleInfoResponse));
 
   EXPECT_CALL(local_print_delegate_, OnPrivetPrintingDoneInternal());
 
   // TODO(noamsml): Is encoding spaces as pluses standard?
   EXPECT_TRUE(SuccessfulResponseToURLAndData(
-      GURL("http://10.0.0.8:6006/privet/printer/submitdoc?"
-           "client_name=Chrome&user_name=sample%40gmail.com&"
-           "job_name=Sample+job+name"),
-      "Sample print data",
-      kSampleLocalPrintResponse));
+      GetUrl("/privet/printer/submitdoc?"
+             "client_name=Chrome&user_name=sample%40gmail.com&"
+             "job_name=Sample+job+name"),
+      "Sample print data", kSampleLocalPrintResponse));
 }
 
-TEST_F(PrivetLocalPrintTest, SuccessfulPWGLocalPrint) {
+TEST_P(PrivetLocalPrintTest, SuccessfulPWGLocalPrint) {
   local_print_operation_->SetUsername("sample@gmail.com");
   local_print_operation_->SetJobname("Sample job name");
   local_print_operation_->SetData(
       RefCountedBytesFromString("path/to/"));
   local_print_operation_->SetCapabilities(kSampleCapabilitiesResponsePWGOnly);
   local_print_operation_->Start();
 
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/info"),
-      kSampleInfoResponse));
+  EXPECT_TRUE(
+      SuccessfulResponseToURL(GetUrl("/privet/info"), kSampleInfoResponse));
 
-  EXPECT_TRUE(SuccessfulResponseToURL(GURL("http://10.0.0.8:6006/privet/info"),
-                                      kSampleInfoResponse));
+  EXPECT_TRUE(
+      SuccessfulResponseToURL(GetUrl("/privet/info"), kSampleInfoResponse));
 
   EXPECT_CALL(local_print_delegate_, OnPrivetPrintingDoneInternal());
 
   // TODO(noamsml): Is encoding spaces as pluses standard?
   EXPECT_TRUE(SuccessfulResponseToURLAndFilePath(
-      GURL("http://10.0.0.8:6006/privet/printer/submitdoc?"
-           "client_name=Chrome&user_name=sample%40gmail.com"
-           "&job_name=Sample+job+name"),
+      GetUrl("/privet/printer/submitdoc?"
+             "client_name=Chrome&user_name=sample%40gmail.com"
+             "&job_name=Sample+job+name"),
       base::FilePath(FILE_PATH_LITERAL("path/to/test.pdf")),
       kSampleLocalPrintResponse));
 
   EXPECT_EQ(printing::TRANSFORM_NORMAL,
             pwg_converter_->bitmap_settings().odd_page_transform);
   EXPECT_FALSE(pwg_converter_->bitmap_settings().rotate_all_pages);
   EXPECT_FALSE(pwg_converter_->bitmap_settings().reverse_page_order);
 }
 
-TEST_F(PrivetLocalPrintTest, SuccessfulPWGLocalPrintDuplex) {
+TEST_P(PrivetLocalPrintTest, SuccessfulPWGLocalPrintDuplex) {
   local_print_operation_->SetUsername("sample@gmail.com");
   local_print_operation_->SetJobname("Sample job name");
   local_print_operation_->SetData(RefCountedBytesFromString("path/to/"));
   local_print_operation_->SetTicket(kSampleCJTDuplex);
   local_print_operation_->SetCapabilities(
       kSampleCapabilitiesResponsePWGSettings);
   local_print_operation_->Start();
 
-  EXPECT_TRUE(SuccessfulResponseToURL(GURL("http://10.0.0.8:6006/privet/info"),
+  EXPECT_TRUE(SuccessfulResponseToURL(GetUrl("/privet/info"),
                                       kSampleInfoResponseWithCreatejob));
 
-  EXPECT_TRUE(SuccessfulResponseToURL(GURL("http://10.0.0.8:6006/privet/info"),
-                                      kSampleInfoResponse));
+  EXPECT_TRUE(
+      SuccessfulResponseToURL(GetUrl("/privet/info"), kSampleInfoResponse));
 
   EXPECT_TRUE(SuccessfulResponseToURLAndJSONData(
-      GURL("http://10.0.0.8:6006/privet/printer/createjob"),
-      kSampleCJTDuplex,
+      GetUrl("/privet/printer/createjob"), kSampleCJTDuplex,
       kSampleCreatejobResponse));
 
   EXPECT_CALL(local_print_delegate_, OnPrivetPrintingDoneInternal());
 
   // TODO(noamsml): Is encoding spaces as pluses standard?
   EXPECT_TRUE(SuccessfulResponseToURLAndFilePath(
-      GURL(
-          "http://10.0.0.8:6006/privet/printer/submitdoc?"
-          "client_name=Chrome&user_name=sample%40gmail.com"
-          "&job_name=Sample+job+name&job_id=1234"),
+      GetUrl("/privet/printer/submitdoc?"
+             "client_name=Chrome&user_name=sample%40gmail.com"
+             "&job_name=Sample+job+name&job_id=1234"),
       base::FilePath(FILE_PATH_LITERAL("path/to/test.pdf")),
       kSampleLocalPrintResponse));
 
   EXPECT_EQ(printing::TRANSFORM_ROTATE_180,
             pwg_converter_->bitmap_settings().odd_page_transform);
   EXPECT_FALSE(pwg_converter_->bitmap_settings().rotate_all_pages);
   EXPECT_TRUE(pwg_converter_->bitmap_settings().reverse_page_order);
 }
 
-TEST_F(PrivetLocalPrintTest, SuccessfulLocalPrintWithCreatejob) {
+TEST_P(PrivetLocalPrintTest, SuccessfulLocalPrintWithCreatejob) {
   local_print_operation_->SetUsername("sample@gmail.com");
   local_print_operation_->SetJobname("Sample job name");
   local_print_operation_->SetTicket(kSampleCJT);
   local_print_operation_->SetData(
       RefCountedBytesFromString("Sample print data"));
   local_print_operation_->SetCapabilities(kSampleCapabilitiesResponse);
   local_print_operation_->Start();
 
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/info"),
-      kSampleInfoResponseWithCreatejob));
+  EXPECT_TRUE(SuccessfulResponseToURL(GetUrl("/privet/info"),
+                                      kSampleInfoResponseWithCreatejob));
 
-  EXPECT_TRUE(SuccessfulResponseToURL(GURL("http://10.0.0.8:6006/privet/info"),
-                                      kSampleInfoResponse));
+  EXPECT_TRUE(
+      SuccessfulResponseToURL(GetUrl("/privet/info"), kSampleInfoResponse));
 
-  EXPECT_TRUE(SuccessfulResponseToURLAndJSONData(
-      GURL("http://10.0.0.8:6006/privet/printer/createjob"),
-      kSampleCJT,
-      kSampleCreatejobResponse));
+  EXPECT_TRUE(
+      SuccessfulResponseToURLAndJSONData(GetUrl("/privet/printer/createjob"),
+                                         kSampleCJT, kSampleCreatejobResponse));
 
   EXPECT_CALL(local_print_delegate_, OnPrivetPrintingDoneInternal());
 
   // TODO(noamsml): Is encoding spaces as pluses standard?
   EXPECT_TRUE(SuccessfulResponseToURLAndData(
-      GURL("http://10.0.0.8:6006/privet/printer/submitdoc?"
-           "client_name=Chrome&user_name=sample%40gmail.com&"
-           "job_name=Sample+job+name&job_id=1234"),
-      "Sample print data",
-      kSampleLocalPrintResponse));
+      GetUrl("/privet/printer/submitdoc?"
+             "client_name=Chrome&user_name=sample%40gmail.com&"
+             "job_name=Sample+job+name&job_id=1234"),
+      "Sample print data", kSampleLocalPrintResponse));
 }
 
-TEST_F(PrivetLocalPrintTest, SuccessfulLocalPrintWithOverlongName) {
+TEST_P(PrivetLocalPrintTest, SuccessfulLocalPrintWithOverlongName) {
   local_print_operation_->SetUsername("sample@gmail.com");
   local_print_operation_->SetJobname(
       "123456789:123456789:123456789:123456789:123456789:123456789:123456789:");
   local_print_operation_->SetTicket(kSampleCJT);
   local_print_operation_->SetCapabilities(kSampleCapabilitiesResponse);
   local_print_operation_->SetData(
       RefCountedBytesFromString("Sample print data"));
   local_print_operation_->Start();
 
-  EXPECT_TRUE(SuccessfulResponseToURL(GURL("http://10.0.0.8:6006/privet/info"),
+  EXPECT_TRUE(SuccessfulResponseToURL(GetUrl("/privet/info"),
                                       kSampleInfoResponseWithCreatejob));
 
-  EXPECT_TRUE(SuccessfulResponseToURL(GURL("http://10.0.0.8:6006/privet/info"),
-                                      kSampleInfoResponse));
+  EXPECT_TRUE(
+      SuccessfulResponseToURL(GetUrl("/privet/info"), kSampleInfoResponse));
 
-  EXPECT_TRUE(SuccessfulResponseToURLAndJSONData(
-      GURL("http://10.0.0.8:6006/privet/printer/createjob"),
-      kSampleCJT,
-      kSampleCreatejobResponse));
+  EXPECT_TRUE(
+      SuccessfulResponseToURLAndJSONData(GetUrl("/privet/printer/createjob"),
+                                         kSampleCJT, kSampleCreatejobResponse));
 
   EXPECT_CALL(local_print_delegate_, OnPrivetPrintingDoneInternal());
 
   // TODO(noamsml): Is encoding spaces as pluses standard?
   EXPECT_TRUE(SuccessfulResponseToURLAndData(
-      GURL(
-          "http://10.0.0.8:6006/privet/printer/submitdoc?"
-          "client_name=Chrome&user_name=sample%40gmail.com&"
-          "job_name=123456789%3A123456789%3A123456789%3A1...123456789"
-          "%3A123456789%3A123456789%3A&job_id=1234"),
-      "Sample print data",
-      kSampleLocalPrintResponse));
+      GetUrl("/privet/printer/submitdoc?"
+             "client_name=Chrome&user_name=sample%40gmail.com&"
+             "job_name=123456789%3A123456789%3A123456789%3A1...123456789"
+             "%3A123456789%3A123456789%3A&job_id=1234"),
+      "Sample print data", kSampleLocalPrintResponse));
 }
 
-TEST_F(PrivetLocalPrintTest, PDFPrintInvalidDocumentTypeRetry) {
+TEST_P(PrivetLocalPrintTest, PDFPrintInvalidDocumentTypeRetry) {
   local_print_operation_->SetUsername("sample@gmail.com");
   local_print_operation_->SetJobname("Sample job name");
   local_print_operation_->SetTicket(kSampleCJT);
   local_print_operation_->SetCapabilities(kSampleCapabilitiesResponse);
   local_print_operation_->SetData(
       RefCountedBytesFromString("sample/path/"));
   local_print_operation_->Start();
 
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/info"),
-      kSampleInfoResponseWithCreatejob));
+  EXPECT_TRUE(SuccessfulResponseToURL(GetUrl("/privet/info"),
+                                      kSampleInfoResponseWithCreatejob));
 
-  EXPECT_TRUE(SuccessfulResponseToURL(GURL("http://10.0.0.8:6006/privet/info"),
-                                      kSampleInfoResponse));
+  EXPECT_TRUE(
+      SuccessfulResponseToURL(GetUrl("/privet/info"), kSampleInfoResponse));
 
-  EXPECT_TRUE(SuccessfulResponseToURLAndJSONData(
-      GURL("http://10.0.0.8:6006/privet/printer/createjob"),
-      kSampleCJT,
-      kSampleCreatejobResponse));
+  EXPECT_TRUE(
+      SuccessfulResponseToURLAndJSONData(GetUrl("/privet/printer/createjob"),
+                                         kSampleCJT, kSampleCreatejobResponse));
 
   // TODO(noamsml): Is encoding spaces as pluses standard?
   EXPECT_TRUE(SuccessfulResponseToURLAndData(
-      GURL("http://10.0.0.8:6006/privet/printer/submitdoc?"
-           "client_name=Chrome&user_name=sample%40gmail.com&"
-           "job_name=Sample+job+name&job_id=1234"),
-      "sample/path/",
-      kSampleInvalidDocumentTypeResponse));
+      GetUrl("/privet/printer/submitdoc?"
+             "client_name=Chrome&user_name=sample%40gmail.com&"
+             "job_name=Sample+job+name&job_id=1234"),
+      "sample/path/", kSampleInvalidDocumentTypeResponse));
 
   EXPECT_CALL(local_print_delegate_, OnPrivetPrintingDoneInternal());
 
   EXPECT_TRUE(SuccessfulResponseToURLAndFilePath(
-      GURL("http://10.0.0.8:6006/privet/printer/submitdoc?"
-           "client_name=Chrome&user_name=sample%40gmail.com&"
-           "job_name=Sample+job+name&job_id=1234"),
+      GetUrl("/privet/printer/submitdoc?"
+             "client_name=Chrome&user_name=sample%40gmail.com&"
+             "job_name=Sample+job+name&job_id=1234"),
       base::FilePath(FILE_PATH_LITERAL("sample/path/test.pdf")),
       kSampleLocalPrintResponse));
 }
 
-TEST_F(PrivetLocalPrintTest, LocalPrintRetryOnInvalidJobID) {
+TEST_P(PrivetLocalPrintTest, LocalPrintRetryOnInvalidJobID) {
   local_print_operation_->SetUsername("sample@gmail.com");
   local_print_operation_->SetJobname("Sample job name");
   local_print_operation_->SetTicket(kSampleCJT);
   local_print_operation_->SetCapabilities(kSampleCapabilitiesResponse);
   local_print_operation_->SetData(
       RefCountedBytesFromString("Sample print data"));
   local_print_operation_->Start();
 
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/info"),
-      kSampleInfoResponseWithCreatejob));
+  EXPECT_TRUE(SuccessfulResponseToURL(GetUrl("/privet/info"),
+                                      kSampleInfoResponseWithCreatejob));
 
-  EXPECT_TRUE(SuccessfulResponseToURL(GURL("http://10.0.0.8:6006/privet/info"),
-                                      kSampleInfoResponse));
+  EXPECT_TRUE(
+      SuccessfulResponseToURL(GetUrl("/privet/info"), kSampleInfoResponse));
 
-  EXPECT_TRUE(SuccessfulResponseToURLAndJSONData(
-      GURL("http://10.0.0.8:6006/privet/printer/createjob"),
-      kSampleCJT,
-      kSampleCreatejobResponse));
+  EXPECT_TRUE(
+      SuccessfulResponseToURLAndJSONData(GetUrl("/privet/printer/createjob"),
+                                         kSampleCJT, kSampleCreatejobResponse));
 
   EXPECT_TRUE(SuccessfulResponseToURLAndData(
-      GURL("http://10.0.0.8:6006/privet/printer/submitdoc?"
-           "client_name=Chrome&user_name=sample%40gmail.com&"
-           "job_name=Sample+job+name&job_id=1234"),
-      "Sample print data",
-      kSampleErrorResponsePrinterBusy));
+      GetUrl("/privet/printer/submitdoc?"
+             "client_name=Chrome&user_name=sample%40gmail.com&"
+             "job_name=Sample+job+name&job_id=1234"),
+      "Sample print data", kSampleErrorResponsePrinterBusy));
 
   RunFor(base::TimeDelta::FromSeconds(3));
 
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/printer/createjob"),
-      kSampleCreatejobResponse));
+  EXPECT_TRUE(SuccessfulResponseToURL(GetUrl("/privet/printer/createjob"),
+                                      kSampleCreatejobResponse));
 }
 #endif  // ENABLE_PRINT_PREVIEW
 
 class PrivetHttpWithServerTest : public ::testing::Test,
                                  public PrivetURLFetcher::Delegate {
  protected:
   PrivetHttpWithServerTest()
       : thread_bundle_(content::TestBrowserThreadBundle::REAL_IO_THREAD) {}
 
   void SetUp() override {
@@ skipping 110 matching lines @@
   fingerprint = {};
   client_->SwitchToHttps(server_->host_port_pair().port(), fingerprint);
   Run();
   EXPECT_FALSE(success_);
   EXPECT_EQ(PrivetURLFetcher::REQUEST_CANCELED, error_);
 }
 
 }  // namespace
 
 }  // namespace local_discovery