Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 1437193002: Initialize session in ::SetUp method instead of constructor (Closed)

Created:
5 years, 1 month ago by Vitaly Buka (NO REVIEWS)
Modified:
5 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@context3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize session in ::SetUp method instead of constructor Session needs to be created after flag is added into command-line. This will be needed by future changes. Committed: https://crrev.com/d93a7df72693d491becf3ae3e23adf49947de07f Cr-Commit-Position: refs/heads/master@{#359457}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -26 lines) Patch
M chrome/browser/extensions/api/gcd_private/privet_v3_session_unittest.cc View 12 chunks +32 lines, -26 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (7 generated)
Vitaly Buka (NO REVIEWS)
5 years, 1 month ago (2015-11-12 17:05:18 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1437193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1437193002/1
5 years, 1 month ago (2015-11-12 17:05:42 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-12 18:40:50 UTC) #7
Aleksey Shlyapnikov
lgtm
5 years, 1 month ago (2015-11-12 19:35:53 UTC) #8
commit-bot: I haz the power
This CL has an open dependency (Issue 1435303002 Patch 1). Please resolve the dependency and ...
5 years, 1 month ago (2015-11-12 19:42:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1437193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1437193002/1
5 years, 1 month ago (2015-11-13 00:41:07 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-13 00:49:59 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 00:50:45 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d93a7df72693d491becf3ae3e23adf49947de07f
Cr-Commit-Position: refs/heads/master@{#359457}

Powered by Google App Engine
This is Rietveld 408576698