[webnfc] NFC is not required to be ActiveDOMObject.

[webnfc] NFC is not required to be ActiveDOMObject.

NFC object is a member of NavigatorNFC that is supplement for Navigator.
Therefore, NFC object will be alive as long as Navigator object exists.
Because of that, inheritance from ActiveDOMObject is not required.

PageLifeCycleObserer is used to fullfill visibility use-case.
https://w3c.github.io/web-nfc/#handling-window-visibility-and-focus

BUG=520391
Committed: https://crrev.com/e2cea06427fc1904111f7a0dc28d1f052d9f52a5
Cr-Commit-Position: refs/heads/master@{#359531}

[shalamov, 2015-11-13 07:38:47]

Description was changed from

==========
[webnfc] NFC is not required to be ActiveDOMObject.

NFC object is a member of NavigatorNFC that is supplement for Navigator.
Therefore, NFC object will be alive as long as Navigator object exists.
Because of that, inheritance from ActiveDOMObject is not required.

PageLifeCycleObserer is used to fullfill visibility use-case.
https://w3c.github.io/web-nfc/#handling-window-visibility-and-focus

BUG=520391
==========

to

==========
[webnfc] NFC is not required to be ActiveDOMObject.

NFC object is a member of NavigatorNFC that is supplement for Navigator.
Therefore, NFC object will be alive as long as Navigator object exists.
Because of that, inheritance from ActiveDOMObject is not required.

PageLifeCycleObserer is used to fullfill visibility use-case.
https://w3c.github.io/web-nfc/#handling-window-visibility-and-focus

BUG=520391
==========

[shalamov, 2015-11-13 07:38:47]

alexander.shalamov@intel.com changed reviewers:
+ jyasskin@chromium.org, kenneth.r.christiansen@intel.com,
rijubrata.bhaumik@intel.com

[shalamov, 2015-11-13 07:47:13]

WebNFC specification has been updated based on TPAC feedback, I'm going to make
few changes to landed code as well as provide implementation for latest spec
snapshot.

PTAL

[kenneth.christiansen, 2015-11-13 08:50:07]

kenneth.christiansen@gmail.com changed reviewers:
+ kenneth.christiansen@gmail.com

[kenneth.christiansen, 2015-11-13 08:50:08]

lgtm

https://codereview.chromium.org/1439063002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/nfc/NFC.idl (right):

https://codereview.chromium.org/1439063002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/nfc/NFC.idl:11: [CallWith=ScriptState]
Promise<NFCAdapter> requestAdapter ();
We got rid of requestAdapter

[kenneth.r.christiansen, 2015-11-13 08:50:40]

lgtm

[kenneth.r.christiansen, 2015-11-13 08:51:01]

The CQ bit was checked by kenneth.r.christiansen@intel.com

[commit-bot: I haz the power, 2015-11-13 08:51:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1439063002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1439063002/1

[commit-bot: I haz the power, 2015-11-13 08:59:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-13 08:59:08]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[shalamov, 2015-11-13 09:36:58]

The CQ bit was checked by alexander.shalamov@intel.com

[shalamov, 2015-11-13 09:36:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
kenneth.r.christiansen@intel.com, kenneth.christiansen@gmail.com
Link to the patchset: https://codereview.chromium.org/1439063002/#ps20001
(title: "Added myself to AUTHORS file")

[commit-bot: I haz the power, 2015-11-13 09:37:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1439063002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1439063002/20001

[shalamov, 2015-11-13 10:02:24]

https://codereview.chromium.org/1439063002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/nfc/NFC.idl (right):

https://codereview.chromium.org/1439063002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/nfc/NFC.idl:11: [CallWith=ScriptState]
Promise<NFCAdapter> requestAdapter ();
On 2015/11/13 08:50:08, kenneth.christiansen wrote:
> We got rid of requestAdapter

I will align with latest spec in following patches, otherwise patchset will be
too big, and it would be difficult to review.

https://codereview.chromium.org/1438043007/

[commit-bot: I haz the power, 2015-11-13 10:43:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-13 10:44:12]

Patchset 2 (id:??) landed as
https://crrev.com/e2cea06427fc1904111f7a0dc28d1f052d9f52a5
Cr-Commit-Position: refs/heads/master@{#359531}