Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: third_party/WebKit/Source/modules/nfc/NFC.h

Issue 1439063002: [webnfc] NFC is not required to be ActiveDOMObject. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added myself to AUTHORS file Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « AUTHORS ('k') | third_party/WebKit/Source/modules/nfc/NFC.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/nfc/NFC.h
diff --git a/third_party/WebKit/Source/modules/nfc/NFC.h b/third_party/WebKit/Source/modules/nfc/NFC.h
index 413cb6f6680b36ee3c67940de47c4705bff6018d..8e8764ddef03a1eb3800979fb89fee5b52b9a460 100644
--- a/third_party/WebKit/Source/modules/nfc/NFC.h
+++ b/third_party/WebKit/Source/modules/nfc/NFC.h
@@ -7,31 +7,37 @@
#include "bindings/core/v8/ScriptPromise.h"
#include "bindings/core/v8/ScriptWrappable.h"
-#include "core/dom/ActiveDOMObject.h"
-#include "core/frame/DOMWindowProperty.h"
-#include "platform/heap/Handle.h"
+#include "core/frame/LocalFrameLifecycleObserver.h"
+#include "core/page/PageLifecycleObserver.h"
namespace blink {
class NFC final
: public GarbageCollectedFinalized<NFC>
, public ScriptWrappable
- , public ActiveDOMObject
- , public DOMWindowProperty {
+ , public LocalFrameLifecycleObserver
+ , public PageLifecycleObserver {
DEFINE_WRAPPERTYPEINFO();
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(NFC);
public:
- static NFC* create(ExecutionContext*, LocalFrame*);
+ static NFC* create(LocalFrame*);
~NFC() override;
// Get an adapter object providing NFC functionality.
ScriptPromise requestAdapter(ScriptState*);
+ // Implementation of LocalFrameLifecycleObserver.
+ void willDetachFrameHost() override;
+
+ // Implementation of PageLifecycleObserver
+ void pageVisibilityChanged() override;
+
+ // Interface required by garbage collection.
DECLARE_VIRTUAL_TRACE();
private:
- NFC(ExecutionContext*, LocalFrame*);
+ NFC(LocalFrame*);
};
} // namespace blink
« no previous file with comments | « AUTHORS ('k') | third_party/WebKit/Source/modules/nfc/NFC.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698