third_party/WebKit/Source/modules/nfc/NFC.idl - Issue 1439063002: [webnfc] NFC is not required to be ActiveDOMObject.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/nfc/NFC.idl

Issue 1439063002: [webnfc] NFC is not required to be ActiveDOMObject. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://w3c.github.io/web-nfc/#idl-def-NFC	5 // https://w3c.github.io/web-nfc/#idl-def-NFC

6	6

7 [	7 [

8 GarbageCollected,	8 GarbageCollected,

9 ActiveDOMObject,

10 RuntimeEnabled=WebNFC,	9 RuntimeEnabled=WebNFC,

11 ] interface NFC {	10 ] interface NFC {

12 [CallWith=ScriptState] Promise<NFCAdapter> requestAdapter ();	11 [CallWith=ScriptState] Promise<NFCAdapter> requestAdapter ();
	kenneth.christiansen 2015/11/13 08:50:08 We got rid of requestAdapter We got rid of requestAdapter shalamov 2015/11/13 10:02:24 I will align with latest spec in following patches Show quoted text On 2015/11/13 08:50:08, kenneth.christiansen wrote: > We got rid of requestAdapter I will align with latest spec in following patches, otherwise patchset will be too big, and it would be difficult to review. https://codereview.chromium.org/1438043007/
13 };	12 };

OLD	NEW

« no previous file with comments | « third_party/WebKit/Source/modules/nfc/NFC.cpp ('k') | third_party/WebKit/Source/modules/nfc/NavigatorNFC.h » ('j') | no next file with comments »