Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: third_party/WebKit/Source/modules/nfc/NFC.cpp

Issue 1439063002: [webnfc] NFC is not required to be ActiveDOMObject. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added myself to AUTHORS file Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "modules/nfc/NFC.h" 6 #include "modules/nfc/NFC.h"
7 7
8 #include "bindings/core/v8/ScriptPromiseResolver.h" 8 #include "bindings/core/v8/ScriptPromiseResolver.h"
9 #include "core/dom/DOMException.h" 9 #include "core/dom/DOMException.h"
10 #include "core/dom/ExceptionCode.h" 10 #include "core/dom/ExceptionCode.h"
11 11
12 namespace blink { 12 namespace blink {
13 13
14 NFC::NFC(ExecutionContext* context, LocalFrame* frame) 14 NFC::NFC(LocalFrame* frame)
15 : ActiveDOMObject(context) 15 : LocalFrameLifecycleObserver(frame)
16 , DOMWindowProperty(frame) 16 , PageLifecycleObserver(frame ? frame->page() : 0)
17 { 17 {
18 } 18 }
19 19
20 NFC* NFC::create(ExecutionContext* context, LocalFrame* frame) 20 NFC* NFC::create(LocalFrame* frame)
21 { 21 {
22 NFC* nfc = new NFC(context, frame); 22 NFC* nfc = new NFC(frame);
23 nfc->suspendIfNeeded();
24 return nfc; 23 return nfc;
25 } 24 }
26 25
27 NFC::~NFC() 26 NFC::~NFC()
28 { 27 {
29 } 28 }
30 29
31 ScriptPromise NFC::requestAdapter(ScriptState* scriptState) 30 ScriptPromise NFC::requestAdapter(ScriptState* scriptState)
32 { 31 {
33 // TODO(riju): To be implemented. 32 // TODO(riju): To be implemented.
34 return ScriptPromise::rejectWithDOMException(scriptState, DOMException::crea te(NotSupportedError)); 33 return ScriptPromise::rejectWithDOMException(scriptState, DOMException::crea te(NotSupportedError));
35 } 34 }
36 35
36 void NFC::willDetachFrameHost()
37 {
38 // TODO(shalamov): To be implemented.
39 }
40
41 void NFC::pageVisibilityChanged()
42 {
43 // TODO(shalamov): To be implemented. When visibility is lost,
44 // NFC operations should be suspended.
45 // https://w3c.github.io/web-nfc/#nfc-suspended
46 }
47
37 DEFINE_TRACE(NFC) 48 DEFINE_TRACE(NFC)
38 { 49 {
39 ActiveDOMObject::trace(visitor); 50 LocalFrameLifecycleObserver::trace(visitor);
40 DOMWindowProperty::trace(visitor); 51 PageLifecycleObserver::trace(visitor);
41 } 52 }
42 53
43 } // namespace blink 54 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/modules/nfc/NFC.h ('k') | third_party/WebKit/Source/modules/nfc/NFC.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698