Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Issue 1437703003: Improves options validation type safety (#24885). (Closed)

Created:
5 years, 1 month ago by pquitslund
Modified:
5 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -35 lines) Patch
M pkg/analysis_server/lib/src/context_manager.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/source/analysis_options_provider.dart View 1 chunk +13 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/task/options.dart View 5 chunks +15 lines, -14 lines 0 comments Download
M pkg/analyzer/test/source/analysis_options_provider_test.dart View 2 chunks +22 lines, -16 lines 0 comments Download
M pkg/analyzer/test/src/task/options_test.dart View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
pquitslund
5 years, 1 month ago (2015-11-12 01:05:25 UTC) #2
scheglov
LGTM
5 years, 1 month ago (2015-11-12 01:42:42 UTC) #3
pquitslund
5 years, 1 month ago (2015-11-12 17:44:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b0a08827aae5094ef7df6777acc3445843961c9b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698