Improves options validation type safety (#24885).

pkg/analyzer/test/source/analysis_options_provider_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.source.analysis_options_provider;
 
 import 'package:analyzer/file_system/memory_file_system.dart';
 import 'package:analyzer/source/analysis_options_provider.dart';
 import 'package:unittest/unittest.dart';
 import 'package:yaml/yaml.dart';
@@ skipping 60 matching lines @@
     setUp(() {
       buildResourceProvider();
     });
     tearDown(() {
       clearResourceProvider();
     });
     test('test_simple', () {
       var optionsProvider = new AnalysisOptionsProvider();
       Map<String, YamlNode> options =
           optionsProvider.getOptions(resourceProvider.getFolder('/'));
-      expect(options.length, equals(1));
+      expect(options, hasLength(1));
       expect(options['analyzer'], isNotNull);
       YamlMap analyzer = options['analyzer'];
-      expect(analyzer.length, equals(1));
+      expect(analyzer, hasLength(1));
       expect(analyzer['ignore'], isNotNull);
       YamlList ignore = analyzer['ignore'];
-      expect(ignore.length, equals(2));
-      expect(ignore[0], equals('ignoreme.dart'));
-      expect(ignore[1], equals('sdk_ext/**'));
+      expect(ignore, hasLength(2));
+      expect(ignore[0], 'ignoreme.dart');
+      expect(ignore[1], 'sdk_ext/**');
     });
     test('test_doesnotexist', () {
       var optionsProvider = new AnalysisOptionsProvider();
       Map<String, YamlNode> options =
           optionsProvider.getOptions(resourceProvider.getFolder('/empty'));
-      expect(options.length, equals(0));
+      expect(options, isEmpty);
     });
   });
   group('AnalysisOptionsProvider', () {
     setUp(() {
       buildResourceProvider(emptyAnalysisOptions: true);
     });
     tearDown(() {
       clearResourceProvider();
     });
     test('test_empty', () {
@@ skipping 17 matching lines @@
         Map<String, YamlNode> options =
             optionsProvider.getOptions(resourceProvider.getFolder('/'));
         expect(options, isNotNull);
       } catch (e) {
         exceptionCaught = true;
       }
       expect(exceptionCaught, isTrue);
     });
   });
   group('AnalysisOptionsProvider', () {
-    test('test_bad_yaml', () {
+    test('test_bad_yaml (1)', () {
       var src = '''
-      analyzer:
-  exclude:
-    - test/data/*
-  error:
-    invalid_assignment: ignore
-    unused_local_variable: # <=== bang
-linter:
-  rules:
-    - camel_case_types
+    analyzer: # <= bang
+strong-mode: true
 ''';
 
       var optionsProvider = new AnalysisOptionsProvider();
       expect(() => optionsProvider.getOptionsFromString(src),
           throwsA(new isInstanceOf<OptionsFormatException>()));
     });
+
+    test('test_bad_yaml (2)', () {
+      var src = '''
+analyzer:
+  strong-mode:true # missing space (sdk/issues/24885)
+''';
+
+      var optionsProvider = new AnalysisOptionsProvider();
+      // Should not throw an exception.
+      var options = optionsProvider.getOptionsFromString(src);
+      // Should return a non-null options list.
+      expect(options, isNotNull);
+    });
   });
 }
 
 MemoryResourceProvider resourceProvider;
 
 buildResourceProvider(
     {bool emptyAnalysisOptions: false, bool badAnalysisOptions: false}) {
   resourceProvider = new MemoryResourceProvider();
   resourceProvider.newFolder('/empty');
   resourceProvider.newFolder('/tmp');
@@ skipping 13 matching lines @@
   }
 }
 
 clearResourceProvider() {
   resourceProvider = null;
 }
 
 emptyResourceProvider() {
   resourceProvider = new MemoryResourceProvider();
 }