Improves options validation type safety (#24885).

pkg/analyzer/test/src/task/options_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.src.task.options_test;
 
 import 'package:analyzer/analyzer.dart';
 import 'package:analyzer/source/analysis_options_provider.dart';
 import 'package:analyzer/src/generated/engine.dart' hide AnalysisContextImpl;
 import 'package:analyzer/src/generated/source.dart';
@@ skipping 75 matching lines @@
     expect(filters.any((filter) => filter(invalid_assignment_error)), isTrue);
   }
 
   test_configure_strong_mode() {
     configureContext('''
 analyzer:
   strong-mode: true
 ''');
     expect(analysisOptions.strongMode, true);
   }
+
+  test_configure_strong_mode_bad_value() {
+    configureContext('''
+analyzer:
+  strong-mode: foo
+''');
+    expect(analysisOptions.strongMode, false);
+  }
+
+  test_configure_bad_options_contents() {
+    configureContext('''
+analyzer:
+  strong-mode:true # misformatted
+''');
+    expect(analysisOptions.strongMode, false);
+  }
 }
 
 @reflectiveTest
 class GenerateOptionsErrorsTaskTest extends AbstractContextTest {
   final optionsFilePath = '/${AnalysisEngine.ANALYSIS_OPTIONS_FILE}';
 
   Source source;
   LineInfo lineInfo(String source) =>
       GenerateOptionsErrorsTask.computeLineInfo(source);
 
@@ skipping 209 matching lines @@
         [AnalysisOptionsWarningCode.UNSUPPORTED_OPTION_WITH_LEGAL_VALUE]);
   }
 
   void validate(String source, List<AnalysisOptionsErrorCode> expected) {
     var options = optionsProvider.getOptionsFromString(source);
     var errors = validator.validate(options);
     expect(errors.map((AnalysisError e) => e.errorCode),
         unorderedEquals(expected));
   }
 }