Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: pkg/analysis_server/lib/src/context_manager.dart

Issue 1437703003: Improves options validation type safety (#24885). (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/lib/source/analysis_options_provider.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/context_manager.dart
diff --git a/pkg/analysis_server/lib/src/context_manager.dart b/pkg/analysis_server/lib/src/context_manager.dart
index 272dafa90008dde32e97c6d4f9bd1a07b0519f40..a3fd86330797a4c620af5db5d437bd1e4e623fdb 100644
--- a/pkg/analysis_server/lib/src/context_manager.dart
+++ b/pkg/analysis_server/lib/src/context_manager.dart
@@ -505,8 +505,8 @@ class ContextManagerImpl implements ContextManager {
}
// Analysis options are processed 'in-line'.
- YamlMap analyzer = options[AnalyzerOptions.analyzer];
- if (analyzer == null) {
+ YamlNode analyzer = options[AnalyzerOptions.analyzer];
+ if (analyzer is! YamlMap) {
// No options for analyzer.
return;
}
« no previous file with comments | « no previous file | pkg/analyzer/lib/source/analysis_options_provider.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698