Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 143653008: Enable sticky positioning for table elements. (Closed)

Created:
6 years, 11 months ago by ostap
Modified:
6 years, 10 months ago
CC:
blink-reviews, zoltan1, dsinclair, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Enable sticky positioning for table elements. Also includes fix for bug ​https://bugs.webkit.org/show_bug.cgi?id=105654 I don't have access to this bug, but from commit message I assume it says about "Heap use after free problem". Debugging showed that it wasn't heap use after free. The real problem that RenderObject::container() returns object which is not RenderBlock and it is used as RenderBlock in RenderBox::containingBlockLogicalHeightForPositioned() method. BUG=231751 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166355

Patch Set 1 #

Patch Set 2 : Add fix for crash in fast/block/sticky-position-con~ng-block-crash.html layout test. #

Patch Set 3 : Got better fix for containingBlock() from webkit and updated by review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -11 lines) Patch
A LayoutTests/fast/css/sticky/sticky-table-row-top.html View 1 chunk +105 lines, -0 lines 0 comments Download
A + LayoutTests/fast/css/sticky/sticky-table-row-top-expected.html View 3 chunks +10 lines, -4 lines 0 comments Download
A LayoutTests/fast/css/sticky/sticky-table-thead-top.html View 1 chunk +111 lines, -0 lines 0 comments Download
A + LayoutTests/fast/css/sticky/sticky-table-thead-top-expected.html View 3 chunks +10 lines, -4 lines 0 comments Download
M Source/core/css/resolver/StyleAdjuster.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBox.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderTableRow.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
ostap
6 years, 11 months ago (2014-01-22 21:56:27 UTC) #1
ojan
lgtm
6 years, 11 months ago (2014-01-24 01:29:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/143653008/1
6 years, 11 months ago (2014-01-24 01:29:40 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=18848
6 years, 11 months ago (2014-01-24 03:51:36 UTC) #4
ostap
6 years, 11 months ago (2014-01-27 22:10:12 UTC) #5
rwlbuis
It seems hasRelativePosition is not really needed since there is only one callsite, and other ...
6 years, 11 months ago (2014-01-27 22:46:25 UTC) #6
ostap
Similar patch was landed here: http://trac.webkit.org/changeset/162960
6 years, 10 months ago (2014-01-28 23:24:18 UTC) #7
dglazkov
lgtm
6 years, 10 months ago (2014-02-03 22:53:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/143653008/220001
6 years, 10 months ago (2014-02-03 22:53:51 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-04 05:43:10 UTC) #10
Message was sent while issue was closed.
Change committed as 166355

Powered by Google App Engine
This is Rietveld 408576698