Source/core/css/resolver/StyleAdjuster.cpp - Issue 143653008: Enable sticky positioning for table elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/StyleAdjuster.cpp

Issue 143653008: Enable sticky positioning for table elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Got better fix for containingBlock() from webkit and updated by review comments. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/resolver/StyleAdjuster.cpp

diff --git a/Source/core/css/resolver/StyleAdjuster.cpp b/Source/core/css/resolver/StyleAdjuster.cpp

index c8fd8aa82ed38fc4e1fcd32ff254bf1d5671a2b7..200a70db92e2dfaef148a60e915ee705a07d09e9 100644

--- a/Source/core/css/resolver/StyleAdjuster.cpp

+++ b/Source/core/css/resolver/StyleAdjuster.cpp

@@ -235,7 +235,7 @@ void StyleAdjuster::adjustRenderStyle(RenderStyle* style, RenderStyle* parentSty

// on some sites).

if ((style->display() == TABLE_HEADER_GROUP || style->display() == TABLE_ROW_GROUP

|| style->display() == TABLE_FOOTER_GROUP || style->display() == TABLE_ROW)

- && style->hasInFlowPosition())

+ && style->position() == RelativePosition)

style->setPosition(StaticPosition);

// writing-mode does not apply to table row groups, table column groups, table rows, and table columns.