Source/core/rendering/RenderBox.cpp - Issue 143653008: Enable sticky positioning for table elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBox.cpp

Issue 143653008: Enable sticky positioning for table elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Got better fix for containingBlock() from webkit and updated by review comments. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderBox.cpp

diff --git a/Source/core/rendering/RenderBox.cpp b/Source/core/rendering/RenderBox.cpp

index 6dab61653e325531de3df6e28b81637c559736d9..13439cb9d896e1469656cd857ce26a08bb6e7cd7 100644

--- a/Source/core/rendering/RenderBox.cpp

+++ b/Source/core/rendering/RenderBox.cpp

@@ -3217,7 +3217,8 @@ LayoutUnit RenderBox::containingBlockLogicalHeightForPositioned(const RenderBoxM

}

if (containingBlock->isBox()) {

- const RenderBlock* cb = toRenderBlock(containingBlock);

+ const RenderBlock* cb = containingBlock->isRenderBlock() ?

+ toRenderBlock(containingBlock) : containingBlock->containingBlock();

LayoutUnit result = cb->clientLogicalHeight();

RenderFlowThread* flowThread = flowThreadContainingBlock();

if (flowThread && containingBlock->isRenderFlowThread() && flowThread->isHorizontalWritingMode() == containingBlock->isHorizontalWritingMode())

« no previous file with comments | « Source/core/css/resolver/StyleAdjuster.cpp ('k') | Source/core/rendering/RenderObject.cpp » ('j') | no next file with comments »