Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Side by Side Diff: Source/core/css/resolver/StyleAdjuster.cpp

Issue 143653008: Enable sticky positioning for table elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Got better fix for containingBlock() from webkit and updated by review comments. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 217 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 // FIXME: Don't support this mutation for pseudo styles like first-lette r or first-line, since it's not completely 228 // FIXME: Don't support this mutation for pseudo styles like first-lette r or first-line, since it's not completely
229 // clear how that should work. 229 // clear how that should work.
230 if (style->display() == INLINE && style->styleType() == NOPSEUDO && styl e->writingMode() != parentStyle->writingMode()) 230 if (style->display() == INLINE && style->styleType() == NOPSEUDO && styl e->writingMode() != parentStyle->writingMode())
231 style->setDisplay(INLINE_BLOCK); 231 style->setDisplay(INLINE_BLOCK);
232 232
233 // After performing the display mutation, check table rows. We do not ho nor position:relative or position:sticky on 233 // After performing the display mutation, check table rows. We do not ho nor position:relative or position:sticky on
234 // table rows or cells. This has been established for position:relative in CSS2.1 (and caused a crash in containingBlock() 234 // table rows or cells. This has been established for position:relative in CSS2.1 (and caused a crash in containingBlock()
235 // on some sites). 235 // on some sites).
236 if ((style->display() == TABLE_HEADER_GROUP || style->display() == TABLE _ROW_GROUP 236 if ((style->display() == TABLE_HEADER_GROUP || style->display() == TABLE _ROW_GROUP
237 || style->display() == TABLE_FOOTER_GROUP || style->display() == TAB LE_ROW) 237 || style->display() == TABLE_FOOTER_GROUP || style->display() == TAB LE_ROW)
238 && style->hasInFlowPosition()) 238 && style->position() == RelativePosition)
239 style->setPosition(StaticPosition); 239 style->setPosition(StaticPosition);
240 240
241 // writing-mode does not apply to table row groups, table column groups, table rows, and table columns. 241 // writing-mode does not apply to table row groups, table column groups, table rows, and table columns.
242 // FIXME: Table cells should be allowed to be perpendicular or flipped w ith respect to the table, though. 242 // FIXME: Table cells should be allowed to be perpendicular or flipped w ith respect to the table, though.
243 if (style->display() == TABLE_COLUMN || style->display() == TABLE_COLUMN _GROUP || style->display() == TABLE_FOOTER_GROUP 243 if (style->display() == TABLE_COLUMN || style->display() == TABLE_COLUMN _GROUP || style->display() == TABLE_FOOTER_GROUP
244 || style->display() == TABLE_HEADER_GROUP || style->display() == TAB LE_ROW || style->display() == TABLE_ROW_GROUP 244 || style->display() == TABLE_HEADER_GROUP || style->display() == TAB LE_ROW || style->display() == TABLE_ROW_GROUP
245 || style->display() == TABLE_CELL) 245 || style->display() == TABLE_CELL)
246 style->setWritingMode(parentStyle->writingMode()); 246 style->setWritingMode(parentStyle->writingMode());
247 247
248 // FIXME: Since we don't support block-flow on flexible boxes yet, disal low setting 248 // FIXME: Since we don't support block-flow on flexible boxes yet, disal low setting
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
410 if (prop.isNamedGridArea() && !map.contains(prop.namedGridLine())) \ 410 if (prop.isNamedGridArea() && !map.contains(prop.namedGridLine())) \
411 style->setGrid##Prop(GridPosition()); 411 style->setGrid##Prop(GridPosition());
412 412
413 CLEAR_UNKNOWN_NAMED_AREA(columnStartPosition, ColumnStart); 413 CLEAR_UNKNOWN_NAMED_AREA(columnStartPosition, ColumnStart);
414 CLEAR_UNKNOWN_NAMED_AREA(columnEndPosition, ColumnEnd); 414 CLEAR_UNKNOWN_NAMED_AREA(columnEndPosition, ColumnEnd);
415 CLEAR_UNKNOWN_NAMED_AREA(rowStartPosition, RowStart); 415 CLEAR_UNKNOWN_NAMED_AREA(rowStartPosition, RowStart);
416 CLEAR_UNKNOWN_NAMED_AREA(rowEndPosition, RowEnd); 416 CLEAR_UNKNOWN_NAMED_AREA(rowEndPosition, RowEnd);
417 } 417 }
418 418
419 } 419 }
OLDNEW
« no previous file with comments | « LayoutTests/fast/css/sticky/sticky-table-thead-top-expected.html ('k') | Source/core/rendering/RenderBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698