Fixed OSX crash in net::URLFetcherCore::URLFetcherCore

chrome/browser/local_discovery/service_discovery_client_mac.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/local_discovery/service_discovery_client_mac.h"
 
 #import <arpa/inet.h>
 #import <Foundation/Foundation.h>
 #import <net/if_dl.h>
 
+#include "base/debug/dump_without_crashing.h"
 #include "base/memory/singleton.h"
 #include "base/metrics/histogram.h"
 #include "base/single_thread_task_runner.h"
 #include "base/thread_task_runner_handle.h"
 #include "base/threading/thread.h"
 #include "net/base/ip_address_number.h"
+#include "net/base/ip_endpoint.h"
 
 using local_discovery::ServiceWatcherImplMac;
 using local_discovery::ServiceResolverImplMac;
 
 @interface NetServiceBrowserDelegate
     : NSObject<NSNetServiceBrowserDelegate, NSNetServiceDelegate> {
  @private
   ServiceWatcherImplMac::NetServiceBrowserContainer* container_;  // weak.
   base::scoped_nsobject<NSMutableArray> services_;
 }
@@ skipping 300 matching lines @@
   [service_ resolveWithTimeout:kResolveTimeout];
 
   VLOG(1) << "ServiceResolverImplMac::NetServiceContainer::"
           << "StartResolvingOnDiscoveryThread: " << service_name_
           << ", instance: " << instance << ", type: " << type
           << ", domain: " << domain;
 }
 
 void ServiceResolverImplMac::NetServiceContainer::OnResolveUpdate(
     RequestStatus status) {
-  if (status == STATUS_SUCCESS) {
-    service_description_.service_name = service_name_;
-
-    for (NSData* address in [service_ addresses]) {
-      const void* bytes = [address bytes];
-      // TODO(justinlin): Handle IPv6 addresses?
-      if (static_cast<const sockaddr*>(bytes)->sa_family == AF_INET) {
-        const sockaddr_in* sock = static_cast<const sockaddr_in*>(bytes);
-        char addr[INET_ADDRSTRLEN];
-        inet_ntop(AF_INET, &sock->sin_addr, addr, INET_ADDRSTRLEN);
-        service_description_.address =
-            net::HostPortPair(addr, ntohs(sock->sin_port));
-        net::ParseIPLiteralToNumber(addr, &service_description_.ip_address);
-        break;
-      }
-    }
-
-    ParseTxtRecord([service_ TXTRecordData], &service_description_.metadata);
-
-    // TODO(justinlin): Implement last_seen.
-    service_description_.last_seen = base::Time::Now();
-    callback_runner_->PostTask(
-        FROM_HERE, base::Bind(callback_, status, service_description_));
-  } else {
+  if (status != STATUS_SUCCESS) {
     callback_runner_->PostTask(
         FROM_HERE, base::Bind(callback_, status, ServiceDescription()));
+    return;
   }
+
+  service_description_.service_name = service_name_;
+
+  for (NSData* address in [service_ addresses]) {
+    const void* bytes = [address bytes];
+    int length = [address length];
+    const sockaddr* socket = static_cast<const sockaddr*>(bytes);
+    net::IPEndPoint end_point;
+    if (end_point.FromSockAddr(socket, length)) {
+      service_description_.address =
+          net::HostPortPair::FromIPEndPoint(end_point);
+      break;
+    }
+  }
+
+  if (service_description_.address.host().empty()) {
+    NOTREACHED() << service_name_;
+    // Unexpected, but could be a reason for crbug.com/513505
+    base::debug::DumpWithoutCrashing();
+    callback_runner_->PostTask(
+        FROM_HERE,
+        base::Bind(callback_, STATUS_KNOWN_NONEXISTENT, ServiceDescription()));
+    return;
+  }
+
+  ParseTxtRecord([service_ TXTRecordData], &service_description_.metadata);
+
+  // TODO(justinlin): Implement last_seen.
+  service_description_.last_seen = base::Time::Now();
+  callback_runner_->PostTask(
+      FROM_HERE, base::Bind(callback_, status, service_description_));
 }
 
 void ServiceResolverImplMac::NetServiceContainer::SetServiceForTesting(
     base::scoped_nsobject<NSNetService> service) {
   service_ = service;
 }
 
 ServiceResolverImplMac::ServiceResolverImplMac(
     const std::string& service_name,
     const ServiceResolver::ResolveCompleteCallback& callback,
@@ skipping 97 matching lines @@
   container_->OnResolveUpdate(local_discovery::ServiceResolver::STATUS_SUCCESS);
 }
 
 - (void)netService:(NSNetService *)sender
         didNotResolve:(NSDictionary *)errorDict {
   container_->OnResolveUpdate(
       local_discovery::ServiceResolver::STATUS_REQUEST_TIMEOUT);
 }
 
 @end