Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 1442923002: Extract resolution logic from PrivetHTTPAsynchronousFactory (Closed)

Created:
5 years, 1 month ago by Vitaly Buka (NO REVIEWS)
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@1436373002
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extract resolution logic from PrivetHTTPAsynchronousFactory BUG=551631, 524788 Committed: https://crrev.com/b0ddd7c02f0f94d16cb699cea37bef3abbf92fda Cr-Commit-Position: refs/heads/master@{#359675}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -83 lines) Patch
A chrome/browser/local_discovery/endpoint_resolver.h View 1 2 1 chunk +56 lines, -0 lines 0 comments Download
A chrome/browser/local_discovery/endpoint_resolver.cc View 1 2 3 4 1 chunk +86 lines, -0 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_asynchronous_factory_impl.h View 1 2 2 chunks +9 lines, -15 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_asynchronous_factory_impl.cc View 1 2 3 chunks +15 lines, -68 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 30 (16 generated)
Vitaly Buka (NO REVIEWS)
5 years, 1 month ago (2015-11-13 07:13:34 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 1436373002 Patch 20001). Please resolve the dependency and ...
5 years, 1 month ago (2015-11-13 07:14:13 UTC) #5
Vitaly Buka (NO REVIEWS)
5 years, 1 month ago (2015-11-13 07:17:10 UTC) #7
Vitaly Buka (NO REVIEWS)
5 years, 1 month ago (2015-11-13 07:17:32 UTC) #9
commit-bot: I haz the power
This CL has an open dependency (Issue 1436373002 Patch 20001). Please resolve the dependency and ...
5 years, 1 month ago (2015-11-13 07:17:39 UTC) #11
Aleksey Shlyapnikov
lgtm What about tests?
5 years, 1 month ago (2015-11-13 16:06:39 UTC) #12
commit-bot: I haz the power
This CL has an open dependency (Issue 1436373002 Patch 20001). Please resolve the dependency and ...
5 years, 1 month ago (2015-11-13 20:09:10 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442923002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442923002/40001
5 years, 1 month ago (2015-11-13 21:09:27 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/123090)
5 years, 1 month ago (2015-11-13 21:22:11 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442923002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442923002/60001
5 years, 1 month ago (2015-11-13 21:36:26 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/29805)
5 years, 1 month ago (2015-11-13 21:49:39 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442923002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442923002/80001
5 years, 1 month ago (2015-11-13 21:56:16 UTC) #28
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 1 month ago (2015-11-13 22:51:23 UTC) #29
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 22:52:22 UTC) #30
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/b0ddd7c02f0f94d16cb699cea37bef3abbf92fda
Cr-Commit-Position: refs/heads/master@{#359675}

Powered by Google App Engine
This is Rietveld 408576698