Fixed OSX crash in net::URLFetcherCore::URLFetcherCore

chrome/browser/local_discovery/privet_http_asynchronous_factory_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/local_discovery/privet_http_asynchronous_factory_impl.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
+#include "base/debug/dump_without_crashing.h"
 #include "base/strings/stringprintf.h"
 #include "chrome/browser/local_discovery/privet_http_impl.h"
 #include "chrome/browser/local_discovery/service_discovery_shared_client.h"
 #include "chrome/common/chrome_switches.h"
 #include "net/base/net_util.h"
 
 namespace local_discovery {
 
 namespace {
 
@@ skipping 56 matching lines @@
     return callback.Run(scoped_ptr<PrivetHTTPClient>());
 
   Start(description.address, callback);
 }
 
 void PrivetHTTPAsynchronousFactoryImpl::ResolutionImpl::Start(
     const net::HostPortPair& address,
     const ResultCallback& callback) {
 #if defined(OS_MACOSX)
   net::IPAddressNumber ip_address;
-  DCHECK(net::ParseIPLiteralToNumber(address.host(), &ip_address));
-  // MAC already has IP there.
-  callback.Run(scoped_ptr<PrivetHTTPClient>(
-      new PrivetHTTPClientImpl(name_, address, request_context_.get())));
+  if (!net::ParseIPLiteralToNumber(address.host(), &ip_address)) {
+    NOTREACHED() << address.ToString();
+    // Unexpected, but could be a reason for crbug.com/513505
+    base::debug::DumpWithoutCrashing();
+    return callback.Run(scoped_ptr<PrivetHTTPClient>());
+  }
+
+  // OSX already has IP there.
+  callback.Run(scoped_ptr<PrivetHTTPClient>(new PrivetHTTPClientImpl(
+      name_, net::HostPortPair::FromIPEndPoint(
+                 net::IPEndPoint(ip_address, address.port())),
+      request_context_.get())));
 #else  // OS_MACOSX
   net::AddressFamily address_family = net::ADDRESS_FAMILY_UNSPECIFIED;
   if (base::CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kPrivetIPv6Only)) {
     address_family = net::ADDRESS_FAMILY_IPV6;
   }
 
   domain_resolver_ = service_discovery_client_->CreateLocalDomainResolver(
       address.host(), address_family,
       base::Bind(&ResolutionImpl::DomainResolveComplete, base::Unretained(this),
@@ skipping 19 matching lines @@
 
   DCHECK(!address.empty());
 
   net::HostPortPair new_address =
       net::HostPortPair(IPAddressToHostString(address), port);
   callback.Run(scoped_ptr<PrivetHTTPClient>(
       new PrivetHTTPClientImpl(name_, new_address, request_context_.get())));
 }
 
 }  // namespace local_discovery