Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issue 1435203003: [x64] Fixed a rounding error on x64 for the Uint64ToF64 conversion. (Closed)

Created:
5 years, 1 month ago by ahaas
Modified:
5 years, 1 month ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x64] Fixed a rounding error on x64 for the Uint64ToF64 conversion. The least significant bit of the input value may affect the result of the conversion through rounding. We OR the least significant with the second least significant bit to preserve it over the SHR instruction. R=titzer@chromium.org Committed: https://crrev.com/71348aa2a07c0c3e2447a7b68296905e2bc3cf86 Cr-Commit-Position: refs/heads/master@{#31969}

Patch Set 1 #

Patch Set 2 : Fixed the test to make it platform independent. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -6 lines) Patch
M src/compiler/x64/code-generator-x64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +5 lines, -1 line 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 1 chunk +153 lines, -1 line 0 comments Download
M test/cctest/compiler/value-helper.h View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
ahaas
5 years, 1 month ago (2015-11-12 15:08:13 UTC) #1
titzer
On 2015/11/12 15:08:13, ahaas wrote: lgtm
5 years, 1 month ago (2015-11-12 19:08:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435203003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435203003/20001
5 years, 1 month ago (2015-11-12 19:34:21 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-12 19:35:52 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-14 23:21:02 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/71348aa2a07c0c3e2447a7b68296905e2bc3cf86
Cr-Commit-Position: refs/heads/master@{#31969}

Powered by Google App Engine
This is Rietveld 408576698