src/compiler/x64/instruction-selector-x64.cc - Issue 1435203003: [x64] Fixed a rounding error on x64 for the Uint64ToF64 conversion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/x64/instruction-selector-x64.cc

Issue 1435203003: [x64] Fixed a rounding error on x64 for the Uint64ToF64 conversion. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fixed the test to make it platform independent. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/x64/instruction-selector-x64.cc

diff --git a/src/compiler/x64/instruction-selector-x64.cc b/src/compiler/x64/instruction-selector-x64.cc

index ac40dd6595f175e325b77f83f6d4788b2172db9d..64850c09dfab75372802bae58b9bf0cf8fa2cf82 100644

--- a/src/compiler/x64/instruction-selector-x64.cc

+++ b/src/compiler/x64/instruction-selector-x64.cc

@@ -973,7 +973,9 @@ void InstructionSelector::VisitRoundInt64ToFloat64(Node* node) {

void InstructionSelector::VisitRoundUint64ToFloat64(Node* node) {

X64OperandGenerator g(this);

- Emit(kSSEUint64ToFloat64, g.DefineAsRegister(node), g.Use(node->InputAt(0)));

+ InstructionOperand temps[] = {g.TempRegister()};

+ Emit(kSSEUint64ToFloat64, g.DefineAsRegister(node), g.Use(node->InputAt(0)),

+ arraysize(temps), temps);

}

« no previous file with comments | « src/compiler/x64/code-generator-x64.cc ('k') | src/x64/macro-assembler-x64.h » ('j') | no next file with comments »