Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/compiler/x64/code-generator-x64.cc

Issue 1435203003: [x64] Fixed a rounding error on x64 for the Uint64ToF64 conversion. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fixed the test to make it platform independent. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/compiler/x64/instruction-selector-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/code-generator.h" 5 #include "src/compiler/code-generator.h"
6 6
7 #include "src/compiler/code-generator-impl.h" 7 #include "src/compiler/code-generator-impl.h"
8 #include "src/compiler/gap-resolver.h" 8 #include "src/compiler/gap-resolver.h"
9 #include "src/compiler/node-matchers.h" 9 #include "src/compiler/node-matchers.h"
10 #include "src/compiler/osr.h" 10 #include "src/compiler/osr.h"
(...skipping 1020 matching lines...) Expand 10 before | Expand all | Expand 10 after
1031 } else { 1031 } else {
1032 __ Cvtqsi2sd(i.OutputDoubleRegister(), i.InputOperand(0)); 1032 __ Cvtqsi2sd(i.OutputDoubleRegister(), i.InputOperand(0));
1033 } 1033 }
1034 break; 1034 break;
1035 case kSSEUint64ToFloat64: 1035 case kSSEUint64ToFloat64:
1036 if (instr->InputAt(0)->IsRegister()) { 1036 if (instr->InputAt(0)->IsRegister()) {
1037 __ movq(kScratchRegister, i.InputRegister(0)); 1037 __ movq(kScratchRegister, i.InputRegister(0));
1038 } else { 1038 } else {
1039 __ movq(kScratchRegister, i.InputOperand(0)); 1039 __ movq(kScratchRegister, i.InputOperand(0));
1040 } 1040 }
1041 __ Cvtqui2sd(i.OutputDoubleRegister(), kScratchRegister); 1041 __ Cvtqui2sd(i.OutputDoubleRegister(), kScratchRegister,
1042 i.TempRegister(0));
1042 break; 1043 break;
1043 case kSSEUint32ToFloat64: 1044 case kSSEUint32ToFloat64:
1044 if (instr->InputAt(0)->IsRegister()) { 1045 if (instr->InputAt(0)->IsRegister()) {
1045 __ movl(kScratchRegister, i.InputRegister(0)); 1046 __ movl(kScratchRegister, i.InputRegister(0));
1046 } else { 1047 } else {
1047 __ movl(kScratchRegister, i.InputOperand(0)); 1048 __ movl(kScratchRegister, i.InputOperand(0));
1048 } 1049 }
1049 __ Cvtqsi2sd(i.OutputDoubleRegister(), kScratchRegister); 1050 __ Cvtqsi2sd(i.OutputDoubleRegister(), kScratchRegister);
1050 break; 1051 break;
1051 case kSSEFloat64ExtractLowWord32: 1052 case kSSEFloat64ExtractLowWord32:
(...skipping 862 matching lines...) Expand 10 before | Expand all | Expand 10 after
1914 int padding_size = last_lazy_deopt_pc_ + space_needed - current_pc; 1915 int padding_size = last_lazy_deopt_pc_ + space_needed - current_pc;
1915 __ Nop(padding_size); 1916 __ Nop(padding_size);
1916 } 1917 }
1917 } 1918 }
1918 1919
1919 #undef __ 1920 #undef __
1920 1921
1921 } // namespace compiler 1922 } // namespace compiler
1922 } // namespace internal 1923 } // namespace internal
1923 } // namespace v8 1924 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/compiler/x64/instruction-selector-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698