Sync: Turn on full history sync by default.

Sync: Turn on full history sync by default.

Full history sync (and history delete directives) were off by default,
but turned on in M27 via an experiment. This meant that history from
signed-in devices was not visible on chrome://history until the browser
was restarted.

This CL make full history sync enabled by default, but retains a
command-line switch and about:flags option to disable it. It also
removes the option to disable delete directives only, since that
had the same effect as disabling full history sync.

TBR=brettw@chromium.org
BUG=233098
TEST=Start up Chrome in a fresh profile, and sign in. Go to
chrome://history and ensure that it says "Showing history from your
signed-in devices" at the top of the history page.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196116

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196394

[Patrick Dubroy, 2013-04-18 08:45:41]

Nicolas, please take a look.

[Patrick Dubroy, 2013-04-18 08:46:10]

[-jhawkins, that was a mistake]

[Nicolas Zea, 2013-04-18 17:43:35]

Mostly LG, but do we need to keep the flag around? Can't we just leave it as
having a kDisableFullHistorySync command line switch, like the other datatypes?

https://codereview.chromium.org/14344002/diff/2001/chrome/browser/sync/sync_p...
File chrome/browser/sync/sync_prefs.cc (right):

https://codereview.chromium.org/14344002/diff/2001/chrome/browser/sync/sync_p...
chrome/browser/sync/sync_prefs.cc:418:
pref_groups_[syncer::TYPED_URLS].Put(syncer::SESSIONS);
I think we should have this guarded by !kDisableFullHistorySync. We shouldn't be
enabling sessions with typed urls if history delete directives are not enabled.

[Patrick Dubroy, 2013-04-19 09:58:09]

Ok, I've expunged the "enable" flag. I guess we need to make a server change so
that it will stop sending the experiment?

https://codereview.chromium.org/14344002/diff/2001/chrome/browser/sync/sync_p...
File chrome/browser/sync/sync_prefs.cc (right):

https://codereview.chromium.org/14344002/diff/2001/chrome/browser/sync/sync_p...
chrome/browser/sync/sync_prefs.cc:418:
pref_groups_[syncer::TYPED_URLS].Put(syncer::SESSIONS);
On 2013/04/18 17:43:35, Nicolas Zea wrote:
> I think we should have this guarded by !kDisableFullHistorySync. We shouldn't
be
> enabling sessions with typed urls if history delete directives are not
enabled.

Done.

[Nicolas Zea, 2013-04-19 17:25:43]

LGTM

And yeah, we'll eventually get rid of the server node, but it's harmless in the
meantime.

[Patrick Dubroy, 2013-04-22 13:53:43]

Nicolas, can you take another look? I need to change enable_disable_test.cc and
testing_profile.cc to fix some failing tests.

On 2013/04/19 17:25:43, Nicolas Zea wrote:
> LGTM
> 
> And yeah, we'll eventually get rid of the server node, but it's harmless in
the
> meantime.

[Nicolas Zea, 2013-04-23 01:34:54]

still LGTM, although you'll need an owners for the testing_profile change.
Alternatively you could just move that call to disable web history into the
sync_test.cc

[Patrick Dubroy, 2013-04-23 08:11:10]

Paweł, PTAL at change in testing_profile.cc.

[Paweł Hajdan Jr., 2013-04-23 17:39:20]

LGTM

[commit-bot: I haz the power, 2013-04-23 17:40:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dubroy@chromium.org/14344002/9012

[commit-bot: I haz the power, 2013-04-23 17:40:43]

Presubmit check for 14344002-9012 failed and returned exit status 1.

INFO:root:Found 14 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/browser/sync/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/sync/PRESUBMIT.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    chrome/browser/history/web_history_service_factory.cc

Presubmit checks took 2.4s to calculate.

[commit-bot: I haz the power, 2013-04-24 08:06:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dubroy@chromium.org/14344002/9012

[commit-bot: I haz the power, 2013-04-24 10:42:06]

Change committed as 196116

[Patrick Dubroy, 2013-04-25 14:07:45]

Committed patchset #4 manually as r196394 (presubmit successful).