Sync: Turn on full history sync by default.

chrome/browser/history/web_history_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/history/web_history_service.h"
 
 #include "base/bind.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 84 matching lines @@
       oauth_scopes.insert(kHistoryOAuthScope);
       ProfileOAuth2TokenServiceFactory::GetForProfile(profile_)
           ->InvalidateToken(oauth_scopes, access_token_);
 
       access_token_ = std::string();
       Start();
       return;
     }
     url_fetcher_->GetResponseAsString(&response_body_);
     url_fetcher_.reset();
+    is_pending_ = false;
     callback_.Run(this, true);
-    is_pending_ = false;
+    // It is valid for the callback to delete |this|, so do not access any
+    // members below here.
   }
 
   // OAuth2TokenService::Consumer interface.
   virtual void OnGetTokenSuccess(
       const OAuth2TokenService::Request* request,
       const std::string& access_token,
       const base::Time& expiration_time) OVERRIDE {
     token_request_.reset();
     DCHECK(!access_token.empty());
     access_token_ = access_token;
 
     // Got an access token -- start the actual API request.
     url_fetcher_.reset(CreateUrlFetcher(access_token));
     url_fetcher_->Start();
   }
 
   virtual void OnGetTokenFailure(
       const OAuth2TokenService::Request* request,
       const GoogleServiceAuthError& error) OVERRIDE {
     token_request_.reset();
-    LOG(WARNING) << "Failed to get OAuth token: " << error.ToString();
+    is_pending_ = false;
     callback_.Run(this, false);
-    is_pending_ = false;
+    // It is valid for the callback to delete |this|, so do not access any
+    // members below here.
   }
 
   // Helper for creating a new URLFetcher for the API request.
   net::URLFetcher* CreateUrlFetcher(const std::string& access_token) {
     net::URLFetcher::RequestType request_type = post_data_.empty() ?
         net::URLFetcher::GET : net::URLFetcher::POST;
     net::URLFetcher* fetcher = net::URLFetcher::Create(
         url_, request_type, this);
     fetcher->SetRequestContext(profile_->GetRequestContext());
     fetcher->SetMaxRetriesOn5xx(kMaxRetries);
@@ skipping 227 matching lines @@
     base::Time end_time,
     const ExpireWebHistoryCallback& callback) {
   std::vector<ExpireHistoryArgs> expire_list(1);
   expire_list.back().urls = restrict_urls;
   expire_list.back().begin_time = begin_time;
   expire_list.back().end_time = end_time;
   return ExpireHistory(expire_list, callback);
 }
 
 }  // namespace history