chrome/browser/sync/sync_prefs.cc - Issue 14344002: Sync: Turn on full history sync by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/sync_prefs.cc

Issue 14344002: Sync: Turn on full history sync by default. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix use-after-free. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/sync_prefs.cc

diff --git a/chrome/browser/sync/sync_prefs.cc b/chrome/browser/sync/sync_prefs.cc

index b7798816552b15e46273edd561db8b4c53c0977c..9a2d798893f398564b919e27b08c424a68add0f9 100644

--- a/chrome/browser/sync/sync_prefs.cc

+++ b/chrome/browser/sync/sync_prefs.cc

@@ -411,8 +411,8 @@ void SyncPrefs::RegisterPrefGroups() {

pref_groups_[syncer::PREFERENCES].Put(syncer::SEARCH_ENGINES);

pref_groups_[syncer::TYPED_URLS].Put(syncer::HISTORY_DELETE_DIRECTIVES);

- const CommandLine& command_line = *CommandLine::ForCurrentProcess();

- if (command_line.HasSwitch(switches::kHistoryEnableFullHistorySync)) {

+ if (!CommandLine::ForCurrentProcess()->HasSwitch(

+ switches::kHistoryDisableFullHistorySync)) {

pref_groups_[syncer::TYPED_URLS].Put(syncer::SESSIONS);

pref_groups_[syncer::TYPED_URLS].Put(syncer::FAVICON_IMAGES);

pref_groups_[syncer::TYPED_URLS].Put(syncer::FAVICON_TRACKING);