Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/android/BUILD.gn

Issue 1433873004: GN: Enable proguard for apks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review nites Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/android/rules.gni ('k') | chrome/android/chrome_public_apk_tmpl.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/BUILD.gn
diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn
index 31c4d25c8018389fd2f99659e67dedd6a7ae9f1c..2e42ba84e94c3e11d318969c831cfc5d98d59d50 100644
--- a/chrome/android/BUILD.gn
+++ b/chrome/android/BUILD.gn
@@ -455,7 +455,6 @@ jinja_template("chrome_public_test_apk_manifest") {
# GYP: //chrome/android/chrome_apk.gyp:chrome_public_test_apk
instrumentation_test_apk("chrome_public_test_apk") {
- # TODO(GYP,cjhopman): Does this need version code/name?
apk_name = "ChromePublicTest"
apk_under_test = ":chrome_public_apk"
android_manifest = chrome_public_test_apk_manifest
@@ -464,4 +463,5 @@ instrumentation_test_apk("chrome_public_test_apk") {
"//chrome/android:chrome_shared_test_java",
]
isolate_file = "../chrome_public_test_apk.isolate"
+ proguard_enabled = !is_debug
}
« no previous file with comments | « build/config/android/rules.gni ('k') | chrome/android/chrome_public_apk_tmpl.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698