Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1436083002: Revert of GN: Enable proguard for apks (Closed)

Created:
5 years, 1 month ago by agrieve
Modified:
5 years, 1 month ago
Reviewers:
newt (away)
CC:
chromium-reviews, klundberg+watch_chromium.org, mikecase+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org, pkotwicz
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of GN: Enable proguard for apks (patchset #2 id:20001 of https://codereview.chromium.org/1433873004/ ) Reason for revert: Broke gn-release-builder-l https://uberchromegw.corp.google.com/i/internal.client.clank/builders/gn-release-builder-l/builds/3091/steps/compile/logs/stdio Original issue's description: > GN: Enable proguard for apks > > This moves a little bit more about how to run proguard for test apks into > proguard_utils.py and adds the gn rules/etc for running proguard on apks. > > BUG=554513 TBR=newt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=554513 Committed: https://crrev.com/dcf9bc68fe1ad6131f7570e2b407fd1a228b34e5 Cr-Commit-Position: refs/heads/master@{#359206}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -206 lines) Patch
M build/android/gyp/apk_obfuscate.py View 2 chunks +18 lines, -2 lines 0 comments Download
M build/android/gyp/proguard.py View 2 chunks +2 lines, -4 lines 0 comments Download
M build/android/gyp/util/proguard_util.py View 3 chunks +7 lines, -46 lines 0 comments Download
M build/android/gyp/write_build_config.py View 3 chunks +1 line, -23 lines 0 comments Download
M build/config/android/internal_rules.gni View 5 chunks +35 lines, -77 lines 0 comments Download
M build/config/android/rules.gni View 4 chunks +8 lines, -48 lines 0 comments Download
M chrome/android/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/chrome_public_apk_tmpl.gni View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
agrieve
Created Revert of GN: Enable proguard for apks
5 years, 1 month ago (2015-11-12 01:32:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436083002/1
5 years, 1 month ago (2015-11-12 01:36:50 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-12 01:39:48 UTC) #3
agrieve
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1435193002/ by agrieve@chromium.org. ...
5 years, 1 month ago (2015-11-12 02:00:44 UTC) #4
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 20:02:41 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dcf9bc68fe1ad6131f7570e2b407fd1a228b34e5
Cr-Commit-Position: refs/heads/master@{#359206}

Powered by Google App Engine
This is Rietveld 408576698