Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1433753002: DevTools: extract filters from TimelinePanel into a class for re-use (Closed)

Created:
5 years, 1 month ago by caseq
Modified:
5 years, 1 month ago
Reviewers:
alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: extract filters from TimelinePanel into a class for re-use Filters will only be shown for Events tab eventually, so extract these into a separate class for ease of moving. BUG= Committed: https://crrev.com/3aeeedfb769904f6f5ae233d44731595eef1e295 Cr-Commit-Position: refs/heads/master@{#359350}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixed tests, addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -107 lines) Patch
M third_party/WebKit/LayoutTests/inspector/tracing/category-filter.html View 1 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-filtering.html View 1 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js View 1 11 chunks +143 lines, -100 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
caseq
5 years, 1 month ago (2015-11-09 22:08:49 UTC) #2
alph
lgtm https://codereview.chromium.org/1433753002/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js (right): https://codereview.chromium.org/1433753002/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js#newcode1964 third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:1964: function textFilterChanged(event) remove arg
5 years, 1 month ago (2015-11-12 02:25:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1433753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1433753002/20001
5 years, 1 month ago (2015-11-12 17:52:49 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-12 18:57:35 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 20:08:42 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3aeeedfb769904f6f5ae233d44731595eef1e295
Cr-Commit-Position: refs/heads/master@{#359350}

Powered by Google App Engine
This is Rietveld 408576698