third_party/WebKit/LayoutTests/inspector/tracing/timeline-filtering.html - Issue 1433753002: DevTools: extract filters from TimelinePanel into a class for re-use

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/tracing/timeline-filtering.html

Issue 1433753002: DevTools: extract filters from TimelinePanel into a class for re-use (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed tests, addressed review comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/tracing/category-filter.html ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/tracing/timeline-filtering.html

diff --git a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-filtering.html b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-filtering.html

index 681608b521a4689fe995aa539f3ab3570828873c..2d1ca2c64ac783184a6e1acb216bd4466b7fad22 100644

--- a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-filtering.html

+++ b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-filtering.html

@@ -79,7 +79,8 @@ function test()

dumpRecords();

InspectorTest.addResult("Filtered by 'bar':");

- panel._filters._textFilterUI.setValue("bar");

+ var textFilterUI = panel._filters._textFilterUI;

+ textFilterUI.setValue("bar");

dumpRecords();

InspectorTest.addResult("Collapsed 'bar04' and 'foo13':");

@@ -94,7 +95,7 @@ function test()

dumpRecords();

InspectorTest.addResult("Filtered by 'foo':");

- panel._filters._textFilterUI.setValue("foo");

+ textFilterUI.setValue("foo");

dumpRecords();

InspectorTest.completeTest();