Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: third_party/WebKit/LayoutTests/inspector/tracing/category-filter.html

Issue 1433753002: DevTools: extract filters from TimelinePanel into a class for re-use (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed tests, addressed review comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/tracing/timeline-filtering.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/inspector/tracing/category-filter.html
diff --git a/third_party/WebKit/LayoutTests/inspector/tracing/category-filter.html b/third_party/WebKit/LayoutTests/inspector/tracing/category-filter.html
index f3eebd98f6de395bac4f88109e1a8bbfd397675b..2855323b781770bbffbfdbf612dabe702dca0975 100644
--- a/third_party/WebKit/LayoutTests/inspector/tracing/category-filter.html
+++ b/third_party/WebKit/LayoutTests/inspector/tracing/category-filter.html
@@ -52,18 +52,19 @@ function test()
for (var i = 0; i < rootRecord.presentationChildren().length; ++i)
rootRecord.presentationChildren()[i].setCollapsed(false);
+ var categoryFilter = WebInspector.panels.timeline._filters._categoryFilter;
InspectorTest.addResult("Original records");
- WebInspector.panels.timeline._categoryFilter.notifyFilterChanged();
+ categoryFilter.notifyFilterChanged();
InspectorTest.dumpVisibleRecords();
InspectorTest.addResult("Visible records when 'loading' is disabled");
WebInspector.TimelineUIUtils.categories().loading.hidden = true;
- WebInspector.panels.timeline._categoryFilter.notifyFilterChanged();
+ categoryFilter.notifyFilterChanged();
InspectorTest.dumpVisibleRecords();
InspectorTest.addResult("Visible records when 'scripting' is disabled");
WebInspector.TimelineUIUtils.categories().scripting.hidden = true;
- WebInspector.panels.timeline._categoryFilter.notifyFilterChanged();
+ categoryFilter.notifyFilterChanged();
InspectorTest.dumpVisibleRecords();
InspectorTest.completeTest();
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/tracing/timeline-filtering.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698