third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js - Issue 1433753002: DevTools: extract filters from TimelinePanel into a class for re-use

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js

Issue 1433753002: DevTools: extract filters from TimelinePanel into a class for re-use (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed tests, addressed review comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js b/third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js

index 856b8e30d88caf3b8fc605ef7279f39b3f5ae36e..fd0c7e571bfa5e8eb7148b0349c54db6e7f8cf62 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js

+++ b/third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js

@@ -629,10 +629,9 @@ WebInspector.ComboBoxFilterUI.prototype = {

/**

- * @param {string} typeName

* @return {*}

- value: function(typeName)

+ value: function()

{

var option = this._options[this._filterComboBox.selectedIndex()];

return option.value;

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js ('k') | no next file » | no next file with comments »