Some first_run code cleanups (extracted from https://codereview.chromium.org/12670013 to keep that …

Some first_run code cleanups (extracted from https://codereview.chromium.org/12670013 to keep that one minimal and to the point).

A) CreateSentinel outside of AutoImport (it didn't belong in there). (this fixes issue 176354 as a side-effect).

B) Move first_run::MasterPrefsPath to first_run::internal:: (it wasn't used outside of first_run).

C) All decisions mapping MasterPreferences to MasterPrefs at first run should happen in SetupMasterPrefsFromInstallPrefs --> removed individual methods that did their own tweak.

D) MasterPrefs default values should be set even if MasterPreferences is NULL.

Precursor CL to https://codereview.chromium.org/12670013.

BUG=219419, 176354
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196317

[gab, 2013-04-18 20:39:52]

Carlos, please take a look.

Thanks!
Gab

[cpu_(ooo_6.6-7.5), 2013-04-21 16:22:58]

lgtm

Some of the moves are hard to track, talk to QA (ananta@) to make sure they do a
pass on this.

[gab, 2013-04-22 16:13:22]

On 2013/04/21 16:22:58, cpu wrote:
> lgtm
> 
> Some of the moves are hard to track, talk to QA (ananta@) to make sure they do
a
> pass on this.

For sure, I will ask them to do a full coverage of the first run preferences
(especially import) after https://codereview.chromium.org/12670013/ lands.

Thanks,
Gab

[gab, 2013-04-22 16:13:56]

Nico, PTAL at the minor tweaks in chrome/browser/chrome_browser_main.cc

Thanks!
Gab

[Nico, 2013-04-22 17:12:57]

lgtm stamp

[commit-bot: I haz the power, 2013-04-24 20:01:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/14328019/23001

[commit-bot: I haz the power, 2013-04-24 22:24:00]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-04-25 03:54:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/14328019/23001

[commit-bot: I haz the power, 2013-04-25 04:55:18]

Change committed as 196317