Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Side by Side Diff: chrome/browser/chrome_browser_main.cc

Issue 14328019: Some first_run code cleanups (extracted from https://codereview.chromium.org/12670013 to keep that … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge up to r196136 Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/first_run/first_run.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chrome_browser_main.h" 5 #include "chrome/browser/chrome_browser_main.h"
6 6
7 #if defined(TOOLKIT_GTK) 7 #if defined(TOOLKIT_GTK)
8 #include <gtk/gtk.h> 8 #include <gtk/gtk.h>
9 #endif 9 #endif
10 10
(...skipping 885 matching lines...) Expand 10 before | Expand all | Expand 10 after
896 // when this value will be updated. 896 // when this value will be updated.
897 local_state_->SetInt64(prefs::kVariationsSeedDate, 897 local_state_->SetInt64(prefs::kVariationsSeedDate,
898 base::Time::Now().ToInternalValue()); 898 base::Time::Now().ToInternalValue());
899 } 899 }
900 900
901 if (!master_prefs_->suppress_default_browser_prompt_for_version.empty()) { 901 if (!master_prefs_->suppress_default_browser_prompt_for_version.empty()) {
902 local_state_->SetString( 902 local_state_->SetString(
903 prefs::kBrowserSuppressDefaultBrowserPrompt, 903 prefs::kBrowserSuppressDefaultBrowserPrompt,
904 master_prefs_->suppress_default_browser_prompt_for_version); 904 master_prefs_->suppress_default_browser_prompt_for_version);
905 } 905 }
906 } else if (parsed_command_line().HasSwitch(switches::kNoFirstRun)) { 906 }
907 // Create the First Run beacon anyways if --no-first-run was passed on the 907
908 // command line. 908 if (do_first_run_tasks_ ||
909 parsed_command_line().HasSwitch(switches::kNoFirstRun)) {
910 // Create the First Run sentinel whether first run tasks are executed
911 // or not.
909 first_run::CreateSentinel(); 912 first_run::CreateSentinel();
910 } 913 }
911 } 914 }
912 #endif 915 #endif
913 916
914 // TODO(viettrungluu): why don't we run this earlier? 917 // TODO(viettrungluu): why don't we run this earlier?
915 if (!parsed_command_line().HasSwitch(switches::kNoErrorDialogs)) 918 if (!parsed_command_line().HasSwitch(switches::kNoErrorDialogs))
916 WarnAboutMinimumSystemRequirements(); 919 WarnAboutMinimumSystemRequirements();
917 920
918 #if defined(OS_LINUX) || defined(OS_OPENBSD) || defined(OS_MACOSX) 921 #if defined(OS_LINUX) || defined(OS_OPENBSD) || defined(OS_MACOSX)
(...skipping 827 matching lines...) Expand 10 before | Expand all | Expand 10 after
1746 if (base::win::GetVersion() <= base::win::VERSION_XP) 1749 if (base::win::GetVersion() <= base::win::VERSION_XP)
1747 uma_name += "_XP"; 1750 uma_name += "_XP";
1748 1751
1749 uma_name += "_PreRead_"; 1752 uma_name += "_PreRead_";
1750 uma_name += pre_read_percentage; 1753 uma_name += pre_read_percentage;
1751 AddPreReadHistogramTime(uma_name.c_str(), time); 1754 AddPreReadHistogramTime(uma_name.c_str(), time);
1752 } 1755 }
1753 #endif 1756 #endif
1754 #endif 1757 #endif
1755 } 1758 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/first_run/first_run.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698